From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58859 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGqcx-0000Wf-Ea for qemu-devel@nongnu.org; Fri, 12 Nov 2010 05:13:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGqcv-0005Mb-Pq for qemu-devel@nongnu.org; Fri, 12 Nov 2010 05:13:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGqcv-0005Ld-Ia for qemu-devel@nongnu.org; Fri, 12 Nov 2010 05:13:01 -0500 Message-ID: <4CDD1343.7090708@redhat.com> Date: Fri, 12 Nov 2010 11:13:23 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1289555831-22844-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1289555831-22844-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] scsi-disk: Move active request asserts List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Nigel Horne , qemu-devel@nongnu.org Am 12.11.2010 10:57, schrieb Stefan Hajnoczi: > SCSI read/write requests should not be re-issued before the current > fragment of I/O completes. There are asserts in scsi-disk.c that guard > this constraint but they trigger on SPARC Linux 2.4. It turns out that > the asserts are too early in the code path and don't allow for read > requests to terminate. > > Only the read assert needs to be moved but move the write assert too for > consistency. > > Reported-by: Nigel Horne > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin