From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] RFC: Aligning arch initialisation sequences
Date: Sun, 14 Nov 2010 14:46:30 +0100 [thread overview]
Message-ID: <4CDFE836.30702@emk-elektronik.de> (raw)
In-Reply-To: <4CDF6070.20503@emk-elektronik.de>
Dear Wolfgang Denk,
To make it crystal clear now, and put the complete context:
That simple change would rid us of all alignment concerns:
Setting stack to end of initial storage will certainly
be aligned, and the auto_gd will be aligned as the
toolchain deems necessary.
We would not need GENERATED_GBL_DATA_SIZE anymore.
The auto_gd space on stack will be valid even into the call
to relocate_code.
> void board_init_f (ulong bootflag)
> {
> bd_t *bd;
> init_fnc_t **init_fnc_ptr;
> gd_t *id;
> ulong addr, addr_sp;
> + gd_t auto_gd;
>
> /* Pointer is writable since we allocated a register for it */
> - gd = (gd_t *) (CONFIG_SYS_INIT_SP_ADDR);
> + gd =&auto_gd;
> /* compiler optimization barrier needed for GCC>= 3.4 */
> /* Q: why is that needed anyway ??? */
> __asm__ __volatile__("": : :"memory");
>
> memset ((void*)gd, 0, sizeof (gd_t));
> ....
> debug ("relocation Offset is: %08lx\n", gd->reloc_off);
> memcpy (id, (void *)gd, sizeof (gd_t));
>
> relocate_code (addr_sp, id, addr);
>
> /* NOTREACHED - relocate_code() does not return */
> }
>
> This, and setting CONFIG_SYS_INIT_SP_ADDR to an aligned value in
> initial storage (SRAM, pinned down Cache, or other) removes alot
> of the headache about making stuff aligned.
>
This three line change DOES NOT propose any different method
of handling gd other then it is currently done.
It is ONLY a more elegant way to allocate the pre-relocation
storage for gd.
Best Regards,
Reinhard
next prev parent reply other threads:[~2010-11-14 13:46 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 10:06 [U-Boot] RFC: Aligning arch initialisation sequences Graeme Russ
2010-11-09 23:35 ` Mike Frysinger
2010-11-13 4:16 ` Graeme Russ
2010-11-13 4:58 ` Mike Frysinger
2010-11-13 6:31 ` Reinhard Meyer
2010-11-13 6:38 ` Reinhard Meyer
2010-11-13 9:51 ` Graeme Russ
2010-11-13 8:17 ` Wolfgang Denk
2010-11-13 21:35 ` Reinhard Meyer
2010-11-13 21:53 ` Wolfgang Denk
2010-11-13 22:38 ` Reinhard Meyer
2010-11-13 22:45 ` Wolfgang Denk
2010-11-13 22:48 ` Reinhard Meyer
2010-11-14 0:07 ` Wolfgang Denk
2010-11-14 0:25 ` Graeme Russ
2010-11-14 0:35 ` Wolfgang Denk
2010-11-14 1:09 ` Graeme Russ
2010-11-14 9:04 ` Wolfgang Denk
2010-11-14 10:21 ` Graeme Russ
2010-11-14 19:43 ` Graeme Russ
2010-11-14 4:07 ` Reinhard Meyer
2010-11-14 9:07 ` Wolfgang Denk
2010-11-14 13:46 ` Reinhard Meyer [this message]
2010-11-14 19:36 ` Graeme Russ
2010-11-14 20:16 ` Reinhard Meyer
2010-11-14 21:01 ` Graeme Russ
2010-11-13 8:20 ` Albert ARIBAUD
2010-11-13 11:18 ` Graeme Russ
2010-11-14 5:10 ` Graeme Russ
2010-11-14 5:48 ` Graeme Russ
2010-11-14 9:16 ` Albert ARIBAUD
2010-11-14 10:30 ` Wolfgang Denk
2010-11-14 12:10 ` Albert ARIBAUD
2010-11-14 15:01 ` Wolfgang Denk
2010-11-14 17:53 ` Albert ARIBAUD
2010-11-14 19:06 ` Wolfgang Denk
2010-11-14 19:29 ` Albert ARIBAUD
2010-11-14 19:55 ` Wolfgang Denk
2010-11-14 20:10 ` Albert ARIBAUD
2010-11-14 20:42 ` Wolfgang Denk
2010-11-14 19:23 ` Wolfgang Denk
2010-11-14 19:34 ` Graeme Russ
2010-11-14 20:05 ` Albert ARIBAUD
2010-11-14 21:27 ` Graeme Russ
2010-11-15 11:08 ` Graeme Russ
2010-11-14 21:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDFE836.30702@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.