From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-devel Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] make trace options use autoconfy names
Date: Sun, 14 Nov 2010 14:52:37 +0100 [thread overview]
Message-ID: <4CDFE9A5.7000706@redhat.com> (raw)
In-Reply-To: <AD55E7D1-DB43-432E-A09F-52DD043969A1@web.de>
On 11/14/2010 02:38 PM, Andreas Färber wrote:
>> - --trace-file=*) trace_file="$optarg"
>> + --enable-trace-file=*) trace_file="$optarg"
>> ;;
>
> but this should be --with-trace-file=... please. It is not being
> enabled, just set to a different value.
--with-* should be reserved for library paths, but I can change it if
people prefer it that way.
Paolo
next prev parent reply other threads:[~2010-11-14 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 11:50 [Qemu-devel] [PATCH] make trace options use autoconfy names Paolo Bonzini
2010-11-14 13:38 ` Andreas Färber
2010-11-14 13:52 ` Paolo Bonzini [this message]
2010-11-15 14:17 ` Stefan Hajnoczi
2010-11-15 15:48 ` Paolo Bonzini
2010-11-15 19:50 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDFE9A5.7000706@redhat.com \
--to=pbonzini@redhat.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.