From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.multimedia-labs.de ([82.149.226.172]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1PHmLb-0004aA-EW for openembedded-devel@lists.openembedded.org; Mon, 15 Nov 2010 00:51:03 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.multimedia-labs.de (Postfix) with ESMTP id 4E089314AB91 for ; Mon, 15 Nov 2010 00:49:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.multimedia-labs.de Received: from mail.multimedia-labs.de ([127.0.0.1]) by localhost (mail.multimedia-labs.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9F0VcTUsCTDa for ; Mon, 15 Nov 2010 00:49:52 +0100 (CET) Received: from [172.22.22.60] (ip-109-90-189-193.unitymediagroup.de [109.90.189.193]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.multimedia-labs.de (Postfix) with ESMTPSA id 33D66314AB8B for ; Mon, 15 Nov 2010 00:49:52 +0100 (CET) Message-ID: <4CE0759F.70000@opendreambox.org> Date: Mon, 15 Nov 2010 00:49:51 +0100 From: Andreas Oberritter User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <4CBEC95F.1000807@opendreambox.org> <1288016445-30478-1-git-send-email-obi@opendreambox.org> <4CDEBCC5.7050401@opendreambox.org> <4CDEE328.6060307@mentor.com> In-Reply-To: <4CDEE328.6060307@mentor.com> X-SA-Exim-Connect-IP: 82.149.226.172 X-SA-Exim-Mail-From: obi@opendreambox.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Re: [PATCH] lib_package.bbclass: fix packaging of static libs, inherit binconfig X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Nov 2010 23:51:04 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 11/13/2010 08:12 PM, Tom Rini wrote: > On 11/13/2010 09:28 AM, Andreas Oberritter wrote: >> Ping >> >> On 10/25/2010 04:20 PM, Andreas Oberritter wrote: >>> * Package ${libdir}/*.a and /lib/*.a into ${PN}-static instead of >>> ${PN}-dev > > Where is the FILES_${PN}-static line below? The default value from bitbake.conf is used. >>> * Although it packaged ${bindir}/*-config into FILES_${PN}-dev, it did >>> not include the required mangling applied by binconfig.bbclass. > > Not sure here. Not all lib packages need binconfig mangling so it's up > to the recipe to say "I need this", usually at least. OK, Koen's proposal included "inherit binconfig", too, so I left it in. I'll send an updated patch without it. >>> Signed-off-by: Andreas Oberritter >>> --- >>> classes/lib_package.bbclass | 17 +++++++++-------- >>> 1 files changed, 9 insertions(+), 8 deletions(-) >>> >>> diff --git a/classes/lib_package.bbclass b/classes/lib_package.bbclass >>> index 82c9370..7e72dc8 100644 >>> --- a/classes/lib_package.bbclass >>> +++ b/classes/lib_package.bbclass >>> @@ -1,10 +1,11 @@ >>> +inherit binconfig >>> + >>> PACKAGES += "${PN}-bin" >>> >>> -FILES_${PN} = "${libexecdir} ${libdir}/lib*${SOLIBS} \ >>> - ${sysconfdir} ${sharedstatedir} ${localstatedir} \ >>> - ${base_libdir}/*${SOLIBS} \ >>> - ${datadir}/${PN} ${libdir}/${PN}" >>> -FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} >>> ${libdir}/*.la \ >>> - ${libdir}/*.a ${libdir}/pkgconfig /lib/*.a /lib/*.o \ >>> - ${datadir}/aclocal ${bindir}/*-config" >>> -FILES_${PN}-bin = "${bindir}/* ${sbindir}/* /bin/* /sbin/*" >>> +FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \ >>> + ${sysconfdir} ${sharedstatedir} ${localstatedir} \ >>> + ${base_libdir}/*${SOLIBS} \ >>> + ${datadir}/${PN} ${libdir}/${PN}/*" >>> + >>> +FILES_${PN}-bin = "${bindir}/* ${sbindir}/* \ >>> + ${base_bindir}/* ${base_sbindir}/*" >> >> >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel >> > >