All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device
Date: Mon, 15 Nov 2010 08:55:07 -0600	[thread overview]
Message-ID: <4CE149CB.1040301@codemonkey.ws> (raw)
In-Reply-To: <m3oc9qr649.fsf@trasno.org>

On 11/15/2010 08:52 AM, Juan Quintela wrote:
> "Michael S. Tsirkin"<mst@redhat.com>  wrote:
>    
>> There's no reason for tap to run when VM is stopped.
>> If we let it, it confuses the bridge on TX
>> and corrupts DMA memory on RX.
>>
>> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>>      
> once here, what handlers make sense to run while stopped?
> /me can think of the normal console, non live migration, loadvm and not
> much more.  Perhaps it is easier to just move the other way around?
>    

I'm not sure I concur that this is really a problem.

Semantically, I don't think that stop has to imply that the guest memory 
no longer changes.

Regards,

Anthony Liguori

> Later, Juan.
>    

  reply	other threads:[~2010-11-15 14:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-04 18:04 [Qemu-devel] [PATCHv2 0/2] migration: stop dma while VM is stopped Michael S. Tsirkin
2010-11-04 18:06 ` [Qemu-devel] [PATCHv2 1/2] char: separate device and system fd handlers Michael S. Tsirkin
2010-11-16 10:24   ` [Qemu-devel] " Juan Quintela
2010-11-04 18:06 ` [Qemu-devel] [PATCHv2 2/2] tap: mark fd handler as device Michael S. Tsirkin
2010-11-15 14:52   ` [Qemu-devel] " Juan Quintela
2010-11-15 14:55     ` Anthony Liguori [this message]
2010-11-15 15:18       ` Michael S. Tsirkin
2010-11-15 16:09         ` Anthony Liguori
2010-11-15 20:26           ` Michael S. Tsirkin
2010-11-15 20:37             ` Anthony Liguori
2010-11-15 20:53           ` Stefan Hajnoczi
2010-11-15 21:05             ` Anthony Liguori
2010-11-15 22:44               ` Michael S. Tsirkin
2010-11-15 23:46                 ` Anthony Liguori
2010-11-15 15:21     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE149CB.1040301@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.