All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Schwarz <andre.schwarz@matrix-vision.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] don't touch non-existent EHCI regs on MPC837x.
Date: Mon, 15 Nov 2010 16:52:12 +0100	[thread overview]
Message-ID: <4CE1572C.6080804@matrix-vision.de> (raw)
In-Reply-To: <20101115152950.30A7B134FEF@gemini.denx.de>

Wolfgang,

> Dear Andre Schwarz,
>
> In message<4CE14E3E.7060208@matrix-vision.de>  you wrote:
>    
>>      
>>> This doesn't seem quite right, the MPC837x has USB controllers.
>>>        
>> yes, it has - and it is working fine.
>> But USB register range 0x00-0xff is reserved and hangs the CPU.
>>
>> With this patch USB is working fine on at least MPC8377.
>>      
> Then the commit message should make this clear.  At the moment it is
> pretty much misleading.
>    

I didn't add this #ifdef but extended it to not only match 834x but also 
837x.

All I see is that the ifdef'ed code accesses registers which are 
explicitely reserved on MPC834x and at least MPC837x.

What would be an appropriate commit message from your point of view ?


Regards,
Andr?

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

  reply	other threads:[~2010-11-15 15:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 14:53 [U-Boot] [PATCH] don't touch non-existent EHCI regs on MPC837x Andre Schwarz
2010-11-15 15:07 ` Kumar Gala
2010-11-15 15:14   ` Andre Schwarz
2010-11-15 15:29     ` Wolfgang Denk
2010-11-15 15:52       ` Andre Schwarz [this message]
2010-11-15 16:16         ` Wolfgang Denk
2010-11-15 16:21           ` Andre Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE1572C.6080804@matrix-vision.de \
    --to=andre.schwarz@matrix-vision.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.