From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Netfilter Development Mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf-next-2.6] netfilter: add __rcu annotations
Date: Mon, 15 Nov 2010 17:53:37 +0100 [thread overview]
Message-ID: <4CE16591.9030504@trash.net> (raw)
In-Reply-To: <1289839592.2607.91.camel@edumazet-laptop>
On 15.11.2010 17:46, Eric Dumazet wrote:
> @@ -49,11 +52,15 @@ EXPORT_SYMBOL(nf_register_queue_handler);
> /* The caller must flush their queue before this */
> int nf_unregister_queue_handler(u_int8_t pf, const struct nf_queue_handler *qh)
> {
> + const struct nf_queue_handler *old;
> +
> if (pf >= ARRAY_SIZE(queue_handler))
> return -EINVAL;
>
> mutex_lock(&queue_handler_mutex);
> - if (queue_handler[pf] && queue_handler[pf] != qh) {
> + old = rcu_dereference_protected(queue_handler[pf],
> + lockdep_is_held(&queue_handler_mutex));
> + if (old && old) {
This doesn't look like it was intended :)
if (old && old != qh)?
next prev parent reply other threads:[~2010-11-15 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 16:46 [PATCH nf-next-2.6] netfilter: add __rcu annotations Eric Dumazet
2010-11-15 16:53 ` Patrick McHardy [this message]
2010-11-15 16:59 ` Eric Dumazet
2010-11-15 17:03 ` Eric Dumazet
2010-11-15 17:17 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE16591.9030504@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.