From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47597 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PI2TK-0004a9-He
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 12:04:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bernhard.kohl@nsn.com>) id 1PI2TE-0000EH-7a
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 12:04:00 -0500
Received: from demumfd002.nsn-inter.net ([93.183.12.31]:11665)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bernhard.kohl@nsn.com>) id 1PI2TD-0000Ds-U3
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 12:03:56 -0500
Message-ID: <4CE167F7.8050709@nsn.com>
Date: Mon, 15 Nov 2010 18:03:51 +0100
From: Bernhard Kohl <bernhard.kohl@nsn.com>
MIME-Version: 1.0
References: <1289821724-24845-1-git-send-email-bernhard.kohl@nsn.com>
In-Reply-To: <1289821724-24845-1-git-send-email-bernhard.kohl@nsn.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] make-release: fix mtime for a wider range
	of git versions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bernhard Kohl <bernhard.kohl@nsn.com>
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, mst@redhat.com

Am 15.11.2010 12:48, schrieb Bernhard Kohl:
> With the latest git versions, e.g. 1.7.2.3, git still prints out
> the tag info in addition to the requested format. So let's simply
> fetch the first line from the output.
>
> In addition I use the --pretty option instead of --format which
> is not recognized in very old git versions, e.g. 1.5.5.6.
>
> Tested with git versions 1.5.5.6 and 1.7.2.3.
>
> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
>    

Sorry, I sent this to the wrong list. Resent to kvm!

Bernhard

> ---
>   kvm/scripts/make-release |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release
> index 56302c3..2d050fc 100755
> --- a/kvm/scripts/make-release
> +++ b/kvm/scripts/make-release
> @@ -51,7 +51,7 @@ cd "$(dirname "$0")"/../..
>   mkdir -p "$(dirname "$tarball")"
>   git archive --prefix="$name/" --format=tar "$commit">  "$tarball"
>
> -mtime=`git show --format=%ct "$commit""^{commit}" --`
> +mtime=`git show --pretty=format:%ct "$commit""^{commit}" -- | head -n 1`
>   tarargs="--owner=root --group=root"
>
>   mkdir -p "$tmpdir/$name"
>