From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Tony Finch <dot@dotat.at>, LKML <linux-kernel@vger.kernel.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] xen: fix header export to userspace
Date: Mon, 15 Nov 2010 10:15:43 -0800 [thread overview]
Message-ID: <4CE178CF.3020308@goop.org> (raw)
In-Reply-To: <20101113084439.d21bd0f0.randy.dunlap@oracle.com>
On 11/13/2010 08:44 AM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> scripts/headers_install.pl prevents "__user" from being exported
> to userspace headers, so just use compiler.h to make sure that
> __user is defined and avoid the error.
>
> unifdef: linux-next-20101112/xx64/usr/include/xen/privcmd.h.tmp: 79: Premature EOF (#if line 33 depth 1)
Ah, OK, thanks. I was wondering what the proper fix for this was. I'll
stick this in my tree.
Thanks,
J
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: xen-devel@lists.xensource.com (moderated for non-subscribers)
> Cc: virtualization@lists.osdl.org
> Cc: Tony Finch <dot@dotat.at>
> ---
> include/xen/privcmd.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- linux-next-20101112.orig/include/xen/privcmd.h
> +++ linux-next-20101112/include/xen/privcmd.h
> @@ -34,13 +34,10 @@
> #define __LINUX_PUBLIC_PRIVCMD_H__
>
> #include <linux/types.h>
> +#include <linux/compiler.h>
>
> typedef unsigned long xen_pfn_t;
>
> -#ifndef __user
> -#define __user
> -#endif
> -
> struct privcmd_hypercall {
> __u64 op;
> __u64 arg[5];
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
akpm <akpm@linux-foundation.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
Tony Finch <dot@dotat.at>
Subject: Re: [PATCH -next] xen: fix header export to userspace
Date: Mon, 15 Nov 2010 10:15:43 -0800 [thread overview]
Message-ID: <4CE178CF.3020308@goop.org> (raw)
In-Reply-To: <20101113084439.d21bd0f0.randy.dunlap@oracle.com>
On 11/13/2010 08:44 AM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> scripts/headers_install.pl prevents "__user" from being exported
> to userspace headers, so just use compiler.h to make sure that
> __user is defined and avoid the error.
>
> unifdef: linux-next-20101112/xx64/usr/include/xen/privcmd.h.tmp: 79: Premature EOF (#if line 33 depth 1)
Ah, OK, thanks. I was wondering what the proper fix for this was. I'll
stick this in my tree.
Thanks,
J
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: xen-devel@lists.xensource.com (moderated for non-subscribers)
> Cc: virtualization@lists.osdl.org
> Cc: Tony Finch <dot@dotat.at>
> ---
> include/xen/privcmd.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- linux-next-20101112.orig/include/xen/privcmd.h
> +++ linux-next-20101112/include/xen/privcmd.h
> @@ -34,13 +34,10 @@
> #define __LINUX_PUBLIC_PRIVCMD_H__
>
> #include <linux/types.h>
> +#include <linux/compiler.h>
>
> typedef unsigned long xen_pfn_t;
>
> -#ifndef __user
> -#define __user
> -#endif
> -
> struct privcmd_hypercall {
> __u64 op;
> __u64 arg[5];
next prev parent reply other threads:[~2010-11-15 18:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 2:05 linux-next: Tree for November 12 Stephen Rothwell
2010-11-13 16:44 ` [PATCH -next] edac: use BIT_64() to eliminate warnings Randy Dunlap
2010-11-13 16:44 ` Randy Dunlap
2010-11-14 17:54 ` Borislav Petkov
[not found] ` <20101112130547.c2a3c2c1.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-11-13 16:44 ` [PATCH -next] iwlwifi: fix modular legacy build errors Randy Dunlap
2010-11-13 16:44 ` Randy Dunlap
2010-11-13 16:44 ` [PATCH -next] pci-sysfs: fix printk warnings Randy Dunlap
2010-11-13 16:44 ` [PATCH -next] staging: fix iio/gyro typos, build errors Randy Dunlap
2010-11-13 16:44 ` Randy Dunlap
2010-11-13 16:44 ` [PATCH -next] x86/mrst: force support code to be built Randy Dunlap
2010-11-15 13:43 ` Alan Cox
2010-11-13 16:44 ` [PATCH -next] xen: fix header export to userspace Randy Dunlap
2010-11-13 16:44 ` Randy Dunlap
2010-11-15 10:23 ` Tony Finch
2010-11-15 18:15 ` Jeremy Fitzhardinge [this message]
2010-11-15 18:15 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE178CF.3020308@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=dot@dotat.at \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.