From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55335 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI6Dr-0006IU-49 for qemu-devel@nongnu.org; Mon, 15 Nov 2010 16:04:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI5Pi-0007oi-HK for qemu-devel@nongnu.org; Mon, 15 Nov 2010 15:12:31 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:51033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI5Pi-0007oc-5Z for qemu-devel@nongnu.org; Mon, 15 Nov 2010 15:12:30 -0500 Message-ID: <4CE1942A.4060405@mail.berlios.de> Date: Mon, 15 Nov 2010 21:12:26 +0100 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking) References: <1289846383-16456-1-git-send-email-weil@mail.berlios.de> <3600835A-8E76-4490-BBEA-CE5DC23BD87D@web.de> In-Reply-To: <3600835A-8E76-4490-BBEA-CE5DC23BD87D@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Blue Swirl , QEMU Developers Am 15.11.2010 21:01, schrieb Andreas Färber: > Am 15.11.2010 um 19:39 schrieb Stefan Weil: > >> This patch adds more printf format checking. >> >> Additional modifications were needed for this code change: >> >> * alpha-dis.c: The local definition of MAX conflicts with >> a previous definition from osdep.h, so add an #undef. >> >> * dis-asm.h: Add include for fprintf_function (qemu-common.h). >> The standard (now redundant) includes are removed. >> >> * mis-dis.c: > > :-) Thanks. Hopefully nobody will mis-interpret the missing 'p' :-) Maybe Blue Swirl can add it, or simply commit it as it is (so future readers of the commit log have fun, too).