From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 4/4] of/fdt: add kernel command line option for dtb_compat string Date: Mon, 15 Nov 2010 16:27:06 -0800 Message-ID: <4CE1CFDA.7030900@linux.intel.com> References: <855a5a11d04a7c1883675b6a77992c4af85222fd.1289520079.git.dirk.brandewie@gmail.com> <20101114062246.GD2355@angua.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101114062246.GD2355-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/13/2010 10:22 PM, Grant Likely wrote: > > 'char' is completely bogus in this context. Either void or struct > boot_param_header would be more accurate and useful. I believe you > can do: > > extern void __dtb_start; > extern_void __dtb_end; > > And then reference the addresses with &__dtb_start and &__dtb_end. > That would eliminate a lot of the casting below. > Except that doesn't work with gcc 4.5+; you really need to use an array type. -hpa