From: Wolfgang Grandegger <wg@grandegger.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Wolfram Sang <w.sang@pengutronix.de>,
Christian Pellegrin <chripell@fsfe.org>,
Barry Song <21cnbao@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew.chih.howe.khor@intel.com,
qi.wang@intel.com, margie.foster@intel.com,
yong.y.wang@intel.com,
Masayuki Ohtake <masa-korg@dsn.okisemi.com>,
kok.howg.ewe@intel.com, joel.clark@intel.com
Subject: Re: [PATCH net-next-2.6 v3] can: Topcliff: PCH_CAN driver: Add Flow control,
Date: Tue, 16 Nov 2010 12:04:43 +0100 [thread overview]
Message-ID: <4CE2654B.20004@grandegger.com> (raw)
In-Reply-To: <4CE2434B.5050701@dsn.okisemi.com>
Hi Tomoya,
On 11/16/2010 09:39 AM, Tomoya MORINAGA wrote:
> Hi Marc and Wolf,
>
> I have updated your indications.
>
>> * Add Flow control
>> * Fix Data copy issue (endianness)
>> * Add Macro prefix "PCH_"
>> * Separate interface register structure
>> * Some functions are unified.
>> * Change MessageObject indication(PCH_RX_OBJ_START, etc..)
>> * Enumerate LEC macro
>> * Move MSI processing from open/close to probe/remove processing
>> * Use BIT(x)
>> * and more...
>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Could you please resend the patch (as v4) with a proper subject and
commit message. Then I will add my "Acked-by" to get that
*not-yet-ready* driver updated quickly.
Wolfgang.
next prev parent reply other threads:[~2010-11-16 11:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 8:39 [PATCH net-next-2.6 v3] can: Topcliff: PCH_CAN driver: Add Flow control, Tomoya MORINAGA
2010-11-16 11:04 ` Wolfgang Grandegger [this message]
2010-11-16 12:22 ` Marc Kleine-Budde
2010-11-16 12:22 ` Marc Kleine-Budde
2010-11-19 6:18 ` Tomoya MORINAGA
2010-11-19 6:18 ` Tomoya MORINAGA
[not found] ` <007401cb87b1$a773b3d0$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-11-19 9:20 ` Marc Kleine-Budde
2010-11-22 5:05 ` Tomoya MORINAGA
2010-11-22 5:05 ` Tomoya MORINAGA
2010-11-22 8:27 ` Marc Kleine-Budde
2010-11-22 8:27 ` Marc Kleine-Budde
2010-11-24 0:09 ` Tomoya MORINAGA
2010-11-24 0:09 ` Tomoya MORINAGA
2010-11-24 12:34 ` Marc Kleine-Budde
2010-11-24 12:34 ` Marc Kleine-Budde
2010-11-25 12:03 ` Tomoya MORINAGA
2010-11-25 12:03 ` Tomoya MORINAGA
2010-11-25 12:08 ` Marc Kleine-Budde
2010-11-25 12:08 ` Marc Kleine-Budde
2010-11-25 12:34 ` Tomoya MORINAGA
2010-11-25 12:34 ` Tomoya MORINAGA
2010-11-25 12:40 ` Marc Kleine-Budde
2010-11-25 12:40 ` Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2010-11-16 8:39 Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2654B.20004@grandegger.com \
--to=wg@grandegger.com \
--cc=21cnbao@gmail.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=w.sang@pengutronix.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.