From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40898 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PILv3-0002yE-OJ
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 08:49:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PILv1-0000Vk-RP
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 08:49:57 -0500
Received: from mail-qy0-f173.google.com ([209.85.216.173]:54693)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PILv1-0000Vc-Ns
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 08:49:55 -0500
Received: by qyl33 with SMTP id 33so5238306qyl.4
	for <qemu-devel@nongnu.org>; Tue, 16 Nov 2010 05:49:55 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CE28BFD.2050400@redhat.com>
Date: Tue, 16 Nov 2010 14:49:49 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1289910517-4576-1-git-send-email-bernhard.kohl@nsn.com>
In-Reply-To: <1289910517-4576-1-git-send-email-bernhard.kohl@nsn.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2] pc: disable the BOCHS BIOS panic port
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bernhard Kohl <bernhard.kohl@nsn.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de

On 11/16/2010 01:28 PM, Bernhard Kohl wrote:
> We have an OS which writes to port 0x400 when probing for special hardware.
> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>
> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
> ---
> Changes v1 ->  v2:
> Keep the ports silent. Don't print debug output if DEBUG_BIOS is enabled
> which might be confusing.
> ---
>   hw/pc.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 3bf3862..76eabe8 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -434,8 +434,8 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>           /* Bochs BIOS messages */
>       case 0x400:
>       case 0x401:
> -        fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
> -        exit(1);
> +        /* used to be panic, now unused */
> +        break;
>       case 0x402:
>       case 0x403:
>   #ifdef DEBUG_BIOS

Reviewed-By: Paolo Bonzini <pbonzini@redhat.com>

Paolo