From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexander Graf <agraf@suse.de>
Cc: Alex Williamson <alex.williamson@redhat.com>,
chrisw@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, ddutile@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support
Date: Tue, 16 Nov 2010 09:08:05 -0600 [thread overview]
Message-ID: <4CE29E55.8010902@codemonkey.ws> (raw)
In-Reply-To: <10D1B822-58CC-4E56-88D5-014FA05E9056@suse.de>
On 11/16/2010 09:02 AM, Alexander Graf wrote:
>>> +static QemuRamSlot *qemu_ram_find_slot(target_phys_addr_t start_addr,
>>> + ram_addr_t size)
>>> +{
>>> + QemuRamSlot *slot;
>>> +
>>> + QLIST_FOREACH(slot,&ram_slots.slots, next) {
>>> + if (slot->start_addr == start_addr&& slot->size == size) {
>>> + return slot;
>>> + }
>>> +
>>> + if (ranges_overlap(start_addr, size, slot->start_addr, slot->size)) {
>>> + abort();
>>>
>>>
>> Should display a message before aborting.
>>
> Why not use hw_error?
>
Another good suggestion.
Regards,
Anthony Liguori
> Alex--
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-11-16 15:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 16:38 [PATCH 0/2] Minimal RAM API support Alex Williamson
2010-10-29 16:39 ` [PATCH 1/2] " Alex Williamson
2010-10-29 19:57 ` [Qemu-devel] " Blue Swirl
2010-10-29 20:15 ` Alex Williamson
2010-11-01 2:17 ` Isaku Yamahata
2010-11-01 2:32 ` Alex Williamson
2010-10-29 16:39 ` [PATCH 2/2] RAM API: Make use of it for x86 PC Alex Williamson
2010-11-01 15:13 ` [PATCH v2 0/2] Minimal RAM API support Alex Williamson
2010-11-01 15:14 ` [PATCH v2 1/2] " Alex Williamson
2010-11-16 14:55 ` [Qemu-devel] " Anthony Liguori
2010-11-16 15:02 ` Alexander Graf
2010-11-16 15:08 ` Anthony Liguori [this message]
2010-11-01 15:14 ` [PATCH v2 2/2] RAM API: Make use of it for x86 PC Alex Williamson
2010-11-16 14:58 ` [Qemu-devel] " Anthony Liguori
2010-11-16 21:24 ` Alex Williamson
2010-11-17 9:31 ` Gleb Natapov
2010-11-17 23:42 ` Anthony Liguori
2010-11-18 15:22 ` Avi Kivity
2010-11-18 15:46 ` Anthony Liguori
2010-11-18 15:57 ` Avi Kivity
2010-11-18 16:09 ` Anthony Liguori
2010-11-18 16:18 ` Avi Kivity
2010-11-18 16:35 ` Michael S. Tsirkin
2010-11-18 15:51 ` Gleb Natapov
2010-11-18 21:41 ` [PATCH v3 0/2] Minimal RAM API support Alex Williamson
2010-11-18 21:41 ` [PATCH v3 1/2] " Alex Williamson
2010-11-18 21:41 ` [PATCH v3 2/2] RAM API: Make use of it for x86 PC Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE29E55.8010902@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=chrisw@redhat.com \
--cc=ddutile@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.