From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43610 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PINYY-0000fd-FF for qemu-devel@nongnu.org; Tue, 16 Nov 2010 10:34:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PINYX-0006Sk-Gs for qemu-devel@nongnu.org; Tue, 16 Nov 2010 10:34:50 -0500 Received: from mail-qy0-f180.google.com ([209.85.216.180]:65482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PINYX-0006RP-EM for qemu-devel@nongnu.org; Tue, 16 Nov 2010 10:34:49 -0500 Received: by qyk36 with SMTP id 36so921623qyk.4 for ; Tue, 16 Nov 2010 07:34:45 -0800 (PST) Message-ID: <4CE2A493.8050708@codemonkey.ws> Date: Tue, 16 Nov 2010 09:34:43 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RESEND][PATCH] Remove 16-character limit on process title References: <20101020191035.GA5674@boost.horde.net> <20101105163549.GA12049@boost.horde.net> In-Reply-To: <20101105163549.GA12049@boost.horde.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Morrissey Cc: qemu-devel@nongnu.org On 11/05/2010 11:35 AM, John Morrissey wrote: > qemu uses prctl() to set its process title. I bumped up against prctl()'s > 16-character limit recently, when adding process title support to > libvirt[1][2]. > > The attached patch overwrites argv instead. Linux seems to maintain the > length of the original args, even when the new args are shorter and > NULL-terminated, so the trailing whitespace in ps(1) output is probably > unavoidable. I've seen the same result with other daemons that overwrite > argv. > > john > > [1] https://www.redhat.com/archives/libvir-list/2010-October/msg00565.html > [2] http://libvirt.org/git/?p=libvirt.git;a=commit;h=c08c7b0143b8cdc542e5f4137623d412340c5cf2 > Needs a Signed-off-by. Regards, Anthony Liguori