diff for duplicates of <4CE2AF5B.7020500@draigBrady.com> diff --git a/a/1.txt b/N1/1.txt index ff73354..4294a0a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,26 +1,23 @@ On 15/11/10 17:05, Josef Bacik wrote: -> Ext4 doesn't have the ability to punch holes yet, so make sure we ret= -urn -> EOPNOTSUPP if we try to use hole punching through fallocate. This su= -pport can +> Ext4 doesn't have the ability to punch holes yet, so make sure we return +> EOPNOTSUPP if we try to use hole punching through fallocate. This support can > be added later. Thanks, ->=20 +> > Signed-off-by: Josef Bacik <josef@redhat.com> > --- > fs/ext4/extents.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) ->=20 +> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0554c48..35bca73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c -> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int m= -ode, loff_t offset, loff_t len) +> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) > struct ext4_map_blocks map; -> unsigned int credits, blkbits =3D inode->i_blkbits; -> =20 +> unsigned int credits, blkbits = inode->i_blkbits; +> > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ -> + if (mode && (mode !=3D FALLOC_FL_KEEP_SIZE)) +> + if (mode && (mode != FALLOC_FL_KEEP_SIZE)) > + return -EOPNOTSUPP; > + > /* @@ -33,4 +30,4 @@ I.E. how do we detect at runtime that the call succeeded and didn't just do a normal fallocate()? cheers, -P=E1draig. +Pádraig. diff --git a/a/content_digest b/N1/content_digest index 1b7c4bf..98d54b5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -16,28 +16,25 @@ "\00:1\0" "b\0" "On 15/11/10 17:05, Josef Bacik wrote:\n" - "> Ext4 doesn't have the ability to punch holes yet, so make sure we ret=\n" - "urn\n" - "> EOPNOTSUPP if we try to use hole punching through fallocate. This su=\n" - "pport can\n" + "> Ext4 doesn't have the ability to punch holes yet, so make sure we return\n" + "> EOPNOTSUPP if we try to use hole punching through fallocate. This support can\n" "> be added later. Thanks,\n" - ">=20\n" + "> \n" "> Signed-off-by: Josef Bacik <josef@redhat.com>\n" "> ---\n" "> fs/ext4/extents.c | 4 ++++\n" "> 1 files changed, 4 insertions(+), 0 deletions(-)\n" - ">=20\n" + "> \n" "> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c\n" "> index 0554c48..35bca73 100644\n" "> --- a/fs/ext4/extents.c\n" "> +++ b/fs/ext4/extents.c\n" - "> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int m=\n" - "ode, loff_t offset, loff_t len)\n" + "> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)\n" "> \tstruct ext4_map_blocks map;\n" - "> \tunsigned int credits, blkbits =3D inode->i_blkbits;\n" - "> =20\n" + "> \tunsigned int credits, blkbits = inode->i_blkbits;\n" + "> \n" "> +\t/* We only support the FALLOC_FL_KEEP_SIZE mode */\n" - "> +\tif (mode && (mode !=3D FALLOC_FL_KEEP_SIZE))\n" + "> +\tif (mode && (mode != FALLOC_FL_KEEP_SIZE))\n" "> +\t\treturn -EOPNOTSUPP;\n" "> +\n" "> \t/*\n" @@ -50,6 +47,6 @@ "and didn't just do a normal fallocate()?\n" "\n" "cheers,\n" - P=E1draig. + "P\303\241draig." -f43d13f1d4ffac6631348ef57625387acfca2c3379dae64d0c5c916a0496b7f9 +ebb2486af7ea55cb1a1b601cf64816d205987bb336c11610e3a0666a1b40d092
diff --git a/a/1.txt b/N2/1.txt index ff73354..9708020 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,26 +1,23 @@ On 15/11/10 17:05, Josef Bacik wrote: -> Ext4 doesn't have the ability to punch holes yet, so make sure we ret= -urn -> EOPNOTSUPP if we try to use hole punching through fallocate. This su= -pport can +> Ext4 doesn't have the ability to punch holes yet, so make sure we return +> EOPNOTSUPP if we try to use hole punching through fallocate. This support can > be added later. Thanks, ->=20 +> > Signed-off-by: Josef Bacik <josef@redhat.com> > --- > fs/ext4/extents.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) ->=20 +> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0554c48..35bca73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c -> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int m= -ode, loff_t offset, loff_t len) +> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) > struct ext4_map_blocks map; -> unsigned int credits, blkbits =3D inode->i_blkbits; -> =20 +> unsigned int credits, blkbits = inode->i_blkbits; +> > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ -> + if (mode && (mode !=3D FALLOC_FL_KEEP_SIZE)) +> + if (mode && (mode != FALLOC_FL_KEEP_SIZE)) > + return -EOPNOTSUPP; > + > /* @@ -33,4 +30,9 @@ I.E. how do we detect at runtime that the call succeeded and didn't just do a normal fallocate()? cheers, -P=E1draig. +Pádraig. + +_______________________________________________ +xfs mailing list +xfs@oss.sgi.com +http://oss.sgi.com/mailman/listinfo/xfs diff --git a/a/content_digest b/N2/content_digest index 1b7c4bf..3d5a842 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,40 +4,36 @@ "Subject\0Re: [PATCH 4/6] Ext4: fail if we try to use hole punch\0" "Date\0Tue, 16 Nov 2010 16:20:43 +0000\0" "To\0Josef Bacik <josef@redhat.com>\0" - "Cc\0david@fromorbit.com" - linux-kernel@vger.kernel.org - linux-btrfs@vger.kernel.org - linux-ext4@vger.kernel.org - linux-fsdevel@vger.kernel.org + "Cc\0linux-kernel@vger.kernel.org" xfs@oss.sgi.com - cmm@us.ibm.com cluster-devel@redhat.com - " ocfs2-devel@oss.oracle.com\0" + cmm@us.ibm.com + ocfs2-devel@oss.oracle.com + linux-fsdevel@vger.kernel.org + linux-ext4@vger.kernel.org + " linux-btrfs@vger.kernel.org\0" "\00:1\0" "b\0" "On 15/11/10 17:05, Josef Bacik wrote:\n" - "> Ext4 doesn't have the ability to punch holes yet, so make sure we ret=\n" - "urn\n" - "> EOPNOTSUPP if we try to use hole punching through fallocate. This su=\n" - "pport can\n" + "> Ext4 doesn't have the ability to punch holes yet, so make sure we return\n" + "> EOPNOTSUPP if we try to use hole punching through fallocate. This support can\n" "> be added later. Thanks,\n" - ">=20\n" + "> \n" "> Signed-off-by: Josef Bacik <josef@redhat.com>\n" "> ---\n" "> fs/ext4/extents.c | 4 ++++\n" "> 1 files changed, 4 insertions(+), 0 deletions(-)\n" - ">=20\n" + "> \n" "> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c\n" "> index 0554c48..35bca73 100644\n" "> --- a/fs/ext4/extents.c\n" "> +++ b/fs/ext4/extents.c\n" - "> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int m=\n" - "ode, loff_t offset, loff_t len)\n" + "> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)\n" "> \tstruct ext4_map_blocks map;\n" - "> \tunsigned int credits, blkbits =3D inode->i_blkbits;\n" - "> =20\n" + "> \tunsigned int credits, blkbits = inode->i_blkbits;\n" + "> \n" "> +\t/* We only support the FALLOC_FL_KEEP_SIZE mode */\n" - "> +\tif (mode && (mode !=3D FALLOC_FL_KEEP_SIZE))\n" + "> +\tif (mode && (mode != FALLOC_FL_KEEP_SIZE))\n" "> +\t\treturn -EOPNOTSUPP;\n" "> +\n" "> \t/*\n" @@ -50,6 +46,11 @@ "and didn't just do a normal fallocate()?\n" "\n" "cheers,\n" - P=E1draig. + "P\303\241draig.\n" + "\n" + "_______________________________________________\n" + "xfs mailing list\n" + "xfs@oss.sgi.com\n" + http://oss.sgi.com/mailman/listinfo/xfs -f43d13f1d4ffac6631348ef57625387acfca2c3379dae64d0c5c916a0496b7f9 +6e88925a40bd31dfb3370d933a5b9725bd585d92c7c9d795cf6474a4049ffe8e
diff --git a/a/1.txt b/N3/1.txt index ff73354..f434dfd 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -1,26 +1,23 @@ On 15/11/10 17:05, Josef Bacik wrote: -> Ext4 doesn't have the ability to punch holes yet, so make sure we ret= -urn -> EOPNOTSUPP if we try to use hole punching through fallocate. This su= -pport can +> Ext4 doesn't have the ability to punch holes yet, so make sure we return +> EOPNOTSUPP if we try to use hole punching through fallocate. This support can > be added later. Thanks, ->=20 +> > Signed-off-by: Josef Bacik <josef@redhat.com> > --- > fs/ext4/extents.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) ->=20 +> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0554c48..35bca73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c -> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int m= -ode, loff_t offset, loff_t len) +> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) > struct ext4_map_blocks map; -> unsigned int credits, blkbits =3D inode->i_blkbits; -> =20 +> unsigned int credits, blkbits = inode->i_blkbits; +> > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ -> + if (mode && (mode !=3D FALLOC_FL_KEEP_SIZE)) +> + if (mode && (mode != FALLOC_FL_KEEP_SIZE)) > + return -EOPNOTSUPP; > + > /* @@ -33,4 +30,4 @@ I.E. how do we detect at runtime that the call succeeded and didn't just do a normal fallocate()? cheers, -P=E1draig. +P?draig. diff --git a/a/content_digest b/N3/content_digest index 1b7c4bf..f61e839 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,8 +1,8 @@ "ref\01289840723-3056-1-git-send-email-josef@redhat.com\0" "ref\01289840723-3056-5-git-send-email-josef@redhat.com\0" "From\0P\303\241draig Brady <P@draigbrady.com>\0" - "Subject\0Re: [PATCH 4/6] Ext4: fail if we try to use hole punch\0" - "Date\0Tue, 16 Nov 2010 16:20:43 +0000\0" + "Subject\0[Ocfs2-devel] [PATCH 4/6] Ext4: fail if we try to use hole punch\0" + "Date\0Tue, 16 Nov 2010 16:21:21 -0000\0" "To\0Josef Bacik <josef@redhat.com>\0" "Cc\0david@fromorbit.com" linux-kernel@vger.kernel.org @@ -16,28 +16,25 @@ "\00:1\0" "b\0" "On 15/11/10 17:05, Josef Bacik wrote:\n" - "> Ext4 doesn't have the ability to punch holes yet, so make sure we ret=\n" - "urn\n" - "> EOPNOTSUPP if we try to use hole punching through fallocate. This su=\n" - "pport can\n" + "> Ext4 doesn't have the ability to punch holes yet, so make sure we return\n" + "> EOPNOTSUPP if we try to use hole punching through fallocate. This support can\n" "> be added later. Thanks,\n" - ">=20\n" + "> \n" "> Signed-off-by: Josef Bacik <josef@redhat.com>\n" "> ---\n" "> fs/ext4/extents.c | 4 ++++\n" "> 1 files changed, 4 insertions(+), 0 deletions(-)\n" - ">=20\n" + "> \n" "> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c\n" "> index 0554c48..35bca73 100644\n" "> --- a/fs/ext4/extents.c\n" "> +++ b/fs/ext4/extents.c\n" - "> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int m=\n" - "ode, loff_t offset, loff_t len)\n" + "> @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)\n" "> \tstruct ext4_map_blocks map;\n" - "> \tunsigned int credits, blkbits =3D inode->i_blkbits;\n" - "> =20\n" + "> \tunsigned int credits, blkbits = inode->i_blkbits;\n" + "> \n" "> +\t/* We only support the FALLOC_FL_KEEP_SIZE mode */\n" - "> +\tif (mode && (mode !=3D FALLOC_FL_KEEP_SIZE))\n" + "> +\tif (mode && (mode != FALLOC_FL_KEEP_SIZE))\n" "> +\t\treturn -EOPNOTSUPP;\n" "> +\n" "> \t/*\n" @@ -50,6 +47,6 @@ "and didn't just do a normal fallocate()?\n" "\n" "cheers,\n" - P=E1draig. + P?draig. -f43d13f1d4ffac6631348ef57625387acfca2c3379dae64d0c5c916a0496b7f9 +64731f369f0e267533368e96b25f4ed4b63e252692685484a3052a0785ecc5c7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.