From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.multimedia-labs.de ([82.149.226.172]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1PIOz4-0001pK-5j for openembedded-devel@lists.openembedded.org; Tue, 16 Nov 2010 18:06:18 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.multimedia-labs.de (Postfix) with ESMTP id 4BC7D314AC66 for ; Tue, 16 Nov 2010 18:05:12 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.multimedia-labs.de Received: from mail.multimedia-labs.de ([127.0.0.1]) by localhost (mail.multimedia-labs.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FD60+ewV4pG6 for ; Tue, 16 Nov 2010 18:05:06 +0100 (CET) Received: from [172.22.22.60] (ip-109-90-189-193.unitymediagroup.de [109.90.189.193]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.multimedia-labs.de (Postfix) with ESMTPSA id 33BE1314AC64 for ; Tue, 16 Nov 2010 18:05:06 +0100 (CET) Message-ID: <4CE2B9C1.6050907@opendreambox.org> Date: Tue, 16 Nov 2010 18:05:05 +0100 From: Andreas Oberritter User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <1288016459-30546-1-git-send-email-obi@opendreambox.org> <4CDEBC78.2020305@opendreambox.org> In-Reply-To: <4CDEBC78.2020305@opendreambox.org> X-SA-Exim-Connect-IP: 82.149.226.172 X-SA-Exim-Mail-From: obi@opendreambox.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Re: [PATCH] pkgconfig.bbclass: don't blindly install every .pc file X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2010 17:06:18 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I think I need to draw some more attention to this patch, because the current way of installing all .pc files from a source tree to sysroot causes build breakage. I'd really prefer this being merged now, so it will make it into the planned december release. Potential problems caused by the patch can still be fixed before release, which means adding an install rule where packages don't install their .pc files themselves. Any opinions? Regards, Andreas On 11/13/2010 05:27 PM, Andreas Oberritter wrote: > Ping > > On 10/25/2010 04:20 PM, Andreas Oberritter wrote: >> * Instead of installing the file, print a log message. Later, >> this function could be removed. >> * .pc files must be installed explicitly to avoid causing >> build problems. E.g. libsoup-2.4-gnome.pc must not be >> installed if libsoup-2.4 is built without gnome support, >> because gstreamer would try to link against libsoup-2.4-gnome. >> * Fixes for lua5.1 and libid3tag, which install their own .pc >> files from OE, have been submitted. >> >> Signed-off-by: Andreas Oberritter >> --- >> classes/pkgconfig.bbclass | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> >> diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass >> index 23ab453..d96b708 100644 >> --- a/classes/pkgconfig.bbclass >> +++ b/classes/pkgconfig.bbclass >> @@ -16,6 +16,8 @@ pkgconfig_sysroot_preprocess () { >> install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR} >> for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do >> pcname=`basename $pc` >> - cat $pc > ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname >> + if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then >> + oenote "$pcname was not installed." >> + fi >> done >> } > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel