From: Anthony Liguori <anthony@codemonkey.ws>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Out off array access in usb-net
Date: Tue, 16 Nov 2010 14:08:13 -0600 [thread overview]
Message-ID: <4CE2E4AD.2040302@codemonkey.ws> (raw)
In-Reply-To: <m31v6uepmm.fsf@blackfin.pond.sub.org>
On 11/09/2010 04:51 AM, Markus Armbruster wrote:
> Gleb Natapov<gleb@redhat.com> writes:
>
>
>> On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote:
>>
>>> Gleb Natapov<gleb@redhat.com> writes:
>>>
>>>
>>>> On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote:
>>>>
>>>>> Gleb Natapov<gleb@redhat.com> writes:
>>>>>
>>>>>
>>>>>> Properly check array bounds before accessing array element.
>>>>>>
>>>>> Impact?
>>>>>
>>>>>
>>>> Gapping security hole for those unfortunate enough to use usb-net?
>>>>
>>> Doesn't that bit of information belong in the commit message.
>>>
>>>
>> Some people prefer not to put such information into commit message.
>>
> Correct, but does "some people" include the QEMU maintainers? Anthony?
>
I don't have a strong opinion either way. If there's a CVE, I'd prefer
the CVE number was prominent in the commit log but other than that, I'd
leave it to the author's discretion.
Regards,
Anthony Liguori
> [...]
>
>
>
next prev parent reply other threads:[~2010-11-16 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 7:36 [Qemu-devel] [PATCH] Out off array access in usb-net Gleb Natapov
2010-11-09 9:29 ` [Qemu-devel] " Paolo Bonzini
2010-11-09 9:30 ` [Qemu-devel] " Markus Armbruster
2010-11-09 9:39 ` Gleb Natapov
2010-11-09 10:16 ` Markus Armbruster
2010-11-09 10:34 ` Gleb Natapov
2010-11-09 10:51 ` Markus Armbruster
2010-11-16 20:08 ` Anthony Liguori [this message]
2010-11-16 20:14 ` Gleb Natapov
2010-11-16 22:24 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2E4AD.2040302@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.