From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56280 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PITxL-0003vH-Pk
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 17:24:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PITxK-00014C-NC
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 17:24:51 -0500
Received: from mail-qw0-f45.google.com ([209.85.216.45]:50340)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PITxK-000148-Je
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 17:24:50 -0500
Received: by qwi2 with SMTP id 2so463806qwi.4
	for <qemu-devel@nongnu.org>; Tue, 16 Nov 2010 14:24:50 -0800 (PST)
Message-ID: <4CE304B2.20407@codemonkey.ws>
Date: Tue, 16 Nov 2010 16:24:50 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need
	to be packed
References: <20101105214030.31799.12838.stgit@s20.home>
In-Reply-To: <20101105214030.31799.12838.stgit@s20.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: jes.sorensen@redhat.com, qemu-devel@nongnu.org

On 11/05/2010 04:40 PM, Alex Williamson wrote:
> We can't let the compiler define the alignment for qemu_cfg data.
>
> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>
>   hw/pc.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 69b13bf..0264e3d 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -75,12 +75,12 @@ struct e820_entry {
>       uint64_t address;
>       uint64_t length;
>       uint32_t type;
> -};
> +} __attribute((__packed__, __aligned__(4)));
>
>   struct e820_table {
>       uint32_t count;
>       struct e820_entry entry[E820_NR_ENTRIES];
> -};
> +} __attribute((__packed__, __aligned__(4)));
>
>   static struct e820_table e820_table;
>
>
>
>
>