From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Jarod Wilson <jarod@redhat.com>
Cc: Nicolas Kaiser <nikai@nikai.net>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/media: nuvoton: always true expression
Date: Tue, 16 Nov 2010 23:51:35 -0200 [thread overview]
Message-ID: <4CE33527.8090800@infradead.org> (raw)
In-Reply-To: <20101116215408.GA17140@redhat.com>
Em 16-11-2010 19:54, Jarod Wilson escreveu:
> On Tue, Nov 16, 2010 at 09:19:53PM +0100, Nicolas Kaiser wrote:
>> I noticed that the second part of this conditional is always true.
>> Would the intention be to strictly check on both chip_major and
>> chip_minor?
>>
>> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
>
> Hrm, yeah, looks like I screwed that one up. You're correct, the intention
> was to make sure we have a matching chip id high and one or the other of
> the chip id low values.
>
> Acked-by: Jarod Wilson <jarod@redhat.com>
>
I wander if it wouldn't be good to print something if the probe fails due to
the wrong chip ID. It may help if someone complain about a different
revision.
Mauro.
next prev parent reply other threads:[~2010-11-17 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 20:19 [PATCH] drivers/media: nuvoton: always true expression Nicolas Kaiser
2010-11-16 21:54 ` Jarod Wilson
2010-11-17 1:51 ` Mauro Carvalho Chehab [this message]
2010-11-17 10:35 ` [PATCH] drivers/media: nuvoton: fix chip id probe Nicolas Kaiser
2010-11-19 19:16 ` Jarod Wilson
2010-11-19 20:42 ` [PATCH] drivers/media: nuvoton: fix chip id probe v2 Nicolas Kaiser
2010-11-19 21:39 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE33527.8090800@infradead.org \
--to=mchehab@infradead.org \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.