All of lore.kernel.org
 help / color / mirror / Atom feed
From: liang Zhen <liang@whamcloud.com>
To: lustre-devel@lists.lustre.org
Subject: [Lustre-devel] extend lnet_notify to public LNet API
Date: Wed, 17 Nov 2010 11:00:53 +0800	[thread overview]
Message-ID: <4CE34565.8060007@whamcloud.com> (raw)
In-Reply-To: <4CE2AAAA.3000508@cray.com>

Nic,

Are you suggesting to provide a new API like:

int LNetNotificationAttach(lnet_notification_callback_t callback);

to register a global callback for LNet, the callback will be called on 
any lnet_notify_locked? If so I don't see any reason we can't do this, 
at least from my point of view. One thing we need to concern is that we 
can't get such a notification for remote peers because no direct 
connection with them in LNDs, we can only get notification for routers 
but upper layer wouldn't be so interested in routers.

Also, seems to me it's a much bigger change in upper layer than in LNet.

Regards
Liang

On 11/17/10 12:00 AM, Nic Henke wrote:
> We'd like to allow upper layers (Lustre, Cray DVS, etc) to register a
> callback that would be called from lnet_notify. This will allow them to
> be notified when the lower layers have seen network problems between
> NIDs and let them take appropriate action. The upper layer could also be
> notified when that peer has returned to 'network health' after the LND
> gets its act together.
>
> This would help allow upper layers to aggressively resend/reconnect in
> the cases where all TX have completed successfully (meaning no LNet -EIO
> on LND errors) but there are LNET_MSG_ACK or other REPLY traffic
> outstanding.
>
> Initial proposal is on the verbose side, giving all data that
> lnet_notify sees:
> - lnet_nid_t
> - is_alive (boolean)
> - cfs_time_t when (unsigned long on Linux) - jiffies when last alive
>
> Is this workable and likely to be accepted up-stream ?
>
> Nic
> _______________________________________________
> Lustre-devel mailing list
> Lustre-devel at lists.lustre.org
> http://lists.lustre.org/mailman/listinfo/lustre-devel

  reply	other threads:[~2010-11-17  3:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16 16:00 [Lustre-devel] extend lnet_notify to public LNet API Nic Henke
2010-11-17  3:00 ` liang Zhen [this message]
2010-11-17  7:52 ` Alexey Lyashkov
2010-11-17 14:59   ` Nic Henke
2010-11-22 17:23     ` Nic Henke
2010-11-22 17:29 ` Nic Henke
2010-11-24 13:10   ` Eric Barton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE34565.8060007@whamcloud.com \
    --to=liang@whamcloud.com \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.