From: Paolo Bonzini <pbonzini@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: skandasa@cisco.com, Anthony Liguori <aliguori@us.ibm.com>,
etmartin@cisco.com, wexu2@cisco.com, mst@redhat.com,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/7] qbus: add functions to walk both devices and busses
Date: Wed, 17 Nov 2010 12:57:53 +0100 [thread overview]
Message-ID: <4CE3C341.9040903@redhat.com> (raw)
In-Reply-To: <61e9609833bd34a1e1766d7b7b9faae6a86503cb.1289969012.git.yamahata@valinux.co.jp>
On 11/17/2010 05:50 AM, Isaku Yamahata wrote:
> +/* Returns 0 to walk children,> 0 to terminate walk,< 0 to skip walk. */
Shouldn't this be the other way round according to the code (< 0 to
terminate, > 0 to skip children)?
> +/* Returns > 0 if either devfn or busfn terminate walk, 0 otherwise. */
This should be "returns != 0". It can return a value > 0 if the
toplevel callback asks to skip the children, < 0 if any callback
(including the toplevel) asks to terminate the walk, 0 otherwise.
Paolo
next prev parent reply other threads:[~2010-11-17 11:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 4:50 [Qemu-devel] [PATCH 0/7] qdev reset refactoring and pci bus reset Isaku Yamahata
2010-11-17 4:50 ` [Qemu-devel] [PATCH 1/7] qbus: add functions to walk both devices and busses Isaku Yamahata
2010-11-17 11:57 ` Paolo Bonzini [this message]
2010-11-17 4:50 ` [Qemu-devel] [PATCH 2/7] qdev: reset qdev along with qdev tree Isaku Yamahata
2010-11-17 4:50 ` [Qemu-devel] [PATCH 3/7] qdev: introduce reset call back for qbus level Isaku Yamahata
2010-11-17 4:50 ` [Qemu-devel] [PATCH 4/7] qdev: introduce a helper function which triggers reset from a given device Isaku Yamahata
2010-11-17 4:50 ` [Qemu-devel] [PATCH 5/7] pci: make use of qdev reset frame work to pci bus reset Isaku Yamahata
2010-11-18 7:02 ` [Qemu-devel] " Michael S. Tsirkin
2010-11-18 8:22 ` Isaku Yamahata
2010-11-18 8:58 ` Michael S. Tsirkin
2010-11-17 4:50 ` [Qemu-devel] [PATCH 6/7] pci: teach pci devices that have reset callback how to reset common registers Isaku Yamahata
2010-11-17 4:50 ` [Qemu-devel] [PATCH 7/7] pci bridge: implement secondary bus reset Isaku Yamahata
2010-11-18 7:05 ` [Qemu-devel] " Michael S. Tsirkin
2010-11-18 7:29 ` Isaku Yamahata
2010-11-18 8:46 ` Michael S. Tsirkin
2010-11-19 8:15 ` Isaku Yamahata
2010-11-19 11:27 ` Michael S. Tsirkin
2010-11-19 12:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE3C341.9040903@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=etmartin@cisco.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=skandasa@cisco.com \
--cc=wexu2@cisco.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.