From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52380 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PIiVY-0005bi-5u
	for qemu-devel@nongnu.org; Wed, 17 Nov 2010 08:57:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PIiVU-0003I4-2M
	for qemu-devel@nongnu.org; Wed, 17 Nov 2010 08:57:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14155)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PIiVT-0003Hf-RJ
	for qemu-devel@nongnu.org; Wed, 17 Nov 2010 08:57:04 -0500
Message-ID: <4CE3DF23.60501@redhat.com>
Date: Wed, 17 Nov 2010 14:56:51 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation
References: <1289955937-24121-1-git-send-email-agraf@suse.de>
	<1289955937-24121-9-git-send-email-agraf@suse.de>
	<4CE39B73.5000302@redhat.com>
	<F9A98CD8-888C-4667-9CE3-58BEC0B68452@suse.de>
In-Reply-To: <F9A98CD8-888C-4667-9CE3-58BEC0B68452@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: tj@kernel.org, Joerg Roedel <Joerg.Roedel@amd.com>, Roland Elek <elek.roland@gmail.com>, QEMU-devel Developers <qemu-devel@nongnu.org>, Sebastian Herbszt <herbszt@gmx.de>

   Hi,

>> Hmm, no bus registered anywhere.  Dunno whenever it makes sense to
>> register ide bus(es) here or whenever we should create a new sata
>> bus.
>
> I'm not sure I understand this comment :).

The ahci controller should register one or more busses where you can 
hook up devices to via -device.  Right now the code seems to use one ide 
bus per sata port, with ide drives being attached to the master channel 
only.  The ide bus isn't registered though, so it isn't visible via 
qdev.  Thus you can't construct a machine with ahci using -device.

Also a ide bus as it works currently isn't exactly a good fit, there is 
no such thing as master/slave in sata.  Dunno whenever it is better to 
create a new sata bus or to extend the current ide bus code so it can 
handle both pata and sata.

Hope it is more clear now ;)

cheers,
   Gerd