All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: alsa-devel <alsa-devel@alsa-project.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: ASoC: Cyclic dependency between soc.h and soc-dapm.h
Date: Wed, 17 Nov 2010 15:33:18 +0100	[thread overview]
Message-ID: <4CE3E7AE.7040308@metafoo.de> (raw)

The commit "ASoC: Decouple DAPM from CODECs" introduced a cyclic dependency between
soc.h and soc-dapm.h which leads to the following compile error, if a driver includes
soc-dapm.h without having included soc.h before:

	In file included from include/sound/soc-dapm.h:19,
	                 from sound/soc/codecs/jz4740.c:25:
	include/sound/soc.h:484: error: field 'dapm' has incomplete type

If soc.h has been included before the error does not happen, but then soc-dapm.h
already got included trough soc.h, so the driver does not really have to include it
again.
So I wonder if soc-dapm.h should be made completely internal and not be included
anywhere else but soc.h anymore?
Or if the cyclic dependency should be broken somehow, maybe by introducing a third
header file?

- Lars

             reply	other threads:[~2010-11-17 14:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 14:33 Lars-Peter Clausen [this message]
2010-11-17 18:44 ` ASoC: Cyclic dependency between soc.h and soc-dapm.h Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE3E7AE.7040308@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.