From: Rick Jones <rick.jones2@hp.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [RFC] don't copy the whole table to all the other CPUs
Date: Wed, 17 Nov 2010 10:03:56 -0800 [thread overview]
Message-ID: <4CE4190C.800@hp.com> (raw)
In-Reply-To: <AANLkTinBSZPAMKb7J0aBb4_xBv_QPnXTZAE9c+8=cnHz@mail.gmail.com>
Changli Gao wrote:
> When reviewing the iptables code, I find there is one exact copy of
> table on every possible CPU for parallel processing. However, only
> counters are private, and the others are the same. It is a wast of
> memory. I know the current implementation maybe good for NUMA, but I
> don't think NUMA is common, and I doubt its benefit. I'll try to
> convert the code use one shared table, but private counters.
>
> Any comment?
Others have already commented on how the code is changing and whether or not
what is done is necessary for good performance in the face of NUMA, but I wanted
to point-out that NUMA is quite common. Just in the x86 space, virtually
anything with two or more sockets sold starting with Nehalem-EP (?) is a NUMA
system, and one can go farther back than that when one goes to Barcelona.
Per-processor memory controllers and more than one processor implies NUMA.
rick jones
prev parent reply other threads:[~2010-11-17 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 14:54 [RFC] don't copy the whole table to all the other CPUs Changli Gao
2010-11-17 14:56 ` Patrick McHardy
2010-11-17 14:57 ` Eric Dumazet
2010-11-17 18:03 ` Rick Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE4190C.800@hp.com \
--to=rick.jones2@hp.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.