All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v2] powerpc/85xx: introduce 'fdt verify' command
Date: Wed, 17 Nov 2010 12:40:50 -0600	[thread overview]
Message-ID: <4CE421B2.8010404@freescale.com> (raw)
In-Reply-To: <20101117182348.F067614EA7E@gemini.denx.de>

Wolfgang Denk wrote:
>> >  struct fdt_header *working_fdt;
>> > @@ -436,6 +450,10 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
>> >  	else if (strncmp(argv[1], "re", 2) == 0) {
>> >  		fdt_resize(working_fdt);
>> >  	}
>> > +	/* verify the addresses in the fdt */
>> > +	else if (argv[1][0] == 'v') {
>> > +		fdt_verify_addresses(working_fdt);
>> > +	}
>> >  	else {
> 2x incorrect coding style - the "else" goes on the saame line with the
> '}' and the '{'
> 

Ah, the bottom half of the switch statement uses this style:

}
else if


But the top half uses this style:

} else if

And the top half is correct.

-- 
Timur Tabi
Linux kernel developer at Freescale

      reply	other threads:[~2010-11-17 18:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 17:43 [U-Boot] [PATCH] [v2] powerpc/85xx: introduce 'fdt verify' command Timur Tabi
2010-11-17 18:23 ` Wolfgang Denk
2010-11-17 18:40   ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE421B2.8010404@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.