From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 0/1][-next] drm/radeon: Move over to the ttm execbuf utilities Date: Wed, 17 Nov 2010 20:56:38 +0100 Message-ID: <4CE43376.6020500@vmware.com> References: <1289997512-16403-1-git-send-email-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com [65.115.85.69]) by gabe.freedesktop.org (Postfix) with ESMTP id 75EDA9EFCE for ; Wed, 17 Nov 2010 11:56:53 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jerome Glisse Cc: "airlied@redhat.com" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On 11/17/2010 08:11 PM, Jerome Glisse wrote: > On Wed, Nov 17, 2010 at 7:38 AM, Thomas Hellstrom wrote: > >> The patch is compile-tested ony and not very intrusive. It should be applied >> on top of the latest TTM patches. >> >> Besides reduced CPU-usage on SMP kernels, there is the benefit of using >> shared code. Will also ease implementation of concurrent CS due to the >> deadlock prevention mechanisms. >> >> If time allows, I'll write a patch to do the same on Novueau, although >> Novueau does things a little differently than the other TTM-aware drivers. >> >> >> > Test on on rs780 and it seems to work properly, but i haven't really > stress test it beside few games. I see no perf or CPU use improvement > but it could very well be hidden by others cost. > Probably. I would have expected that a CPU-bound app, for example ipers if running at 100% CPU (before the patch) would've seen some frame rate improvements.. > Note that we can't really have concurrent cs due to the way checking > work. Anyway you could add my reviewed by. > Thanks, Jerome. /Thomas > Reviewed-by: Jerome Glisse > Tested-by: Jerome Glisse >