From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: lock the page in __ocfs2_page_mkwrite()
Date: Wed, 17 Nov 2010 15:24:18 -0800 [thread overview]
Message-ID: <4CE46422.8030706@oracle.com> (raw)
In-Reply-To: <20101117231732.GD25677@mail.oracle.com>
On 11/17/2010 03:17 PM, Joel Becker wrote:
> On Fri, Nov 05, 2010 at 12:53:16PM +0800, Wengang Wang wrote:
>> Lock the page in __ocfs2_page_mkwrite(). Or we may get -EINVAL error
>> from ocfs2_grab_pages_for_write() if the page(page cache) gets truncated.
> Hmm. Have you seen this happen? Do you have a reproducible
> test case? The inode lock and alloc sem are taken in
> ocfs2_page_mkwrite(), which should prevent real truncation of the file
> and truncation of the page due to downconvert. I think you're saying
> that someone could flush the pagecache and cause a problem here, but I'd
> like to have a testcase.
> Also, earlier in __ocfs2_page_mkwrite() we return 0 when the
> mapping is wrong. Can we do that again?
orabug#10127979
next prev parent reply other threads:[~2010-11-17 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 4:53 [Ocfs2-devel] [PATCH] ocfs2: lock the page in __ocfs2_page_mkwrite() Wengang Wang
2010-11-15 2:12 ` Wengang Wang
2010-11-17 23:17 ` Joel Becker
2010-11-17 23:24 ` Sunil Mushran [this message]
2010-11-17 23:21 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE46422.8030706@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.