From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42884 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PIrvh-0008L4-KA
	for qemu-devel@nongnu.org; Wed, 17 Nov 2010 19:00:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PIrvg-0003jN-26
	for qemu-devel@nongnu.org; Wed, 17 Nov 2010 19:00:45 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:63879)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PIrvf-0003j8-Vj
	for qemu-devel@nongnu.org; Wed, 17 Nov 2010 19:00:44 -0500
Received: by yxf34 with SMTP id 34so1223355yxf.4
	for <qemu-devel@nongnu.org>; Wed, 17 Nov 2010 16:00:43 -0800 (PST)
Message-ID: <4CE46CAD.5070109@codemonkey.ws>
Date: Wed, 17 Nov 2010 18:00:45 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted
	for SystemTAP compatability
References: <1289244788-19961-1-git-send-email-berrange@redhat.com>	<1289244788-19961-2-git-send-email-berrange@redhat.com>	<4CE2A74C.6050302@codemonkey.ws>
	<20101117113554.GA29020@redhat.com>
In-Reply-To: <20101117113554.GA29020@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

On 11/17/2010 05:35 AM, Daniel P. Berrange wrote:
> On Tue, Nov 16, 2010 at 09:46:20AM -0600, Anthony Liguori wrote:
>    
>> On 11/08/2010 01:33 PM, Daniel P. Berrange wrote:
>>      
>>> This introduces a new tracing backend that targets the SystemTAP
>>> implementation of DTrace userspace tracing. The core functionality
>>> should be applicable and standard across any DTrace implementation
>>> on Solaris, OS-X, *BSD, but the Makefile rules will likely need
>>> some small additional changes to cope with OS specific build
>>> requirements.
>>>
>>> This backend builds a little differently from the other tracing
>>> backends. Specifically there is no 'trace.c' file, because the
>>> 'dtrace' command line tool generates a '.o' file directly from
>>> the dtrace probe definition file. The probe definition is usually
>>> named with a '.d' extension but QEMU uses '.d' files for its
>>> external makefile dependancy tracking, so this uses '.dtrace' as
>>> the extension for the probe definition file.
>>>
>>> The 'tracetool' program gains the ability to generate a trace.h
>>> file for DTrace, and also to generate the trace.d file containing
>>> the dtrace probe definition.
>>>
>>> Example usage of a dtrace probe in systemtap looks like:
>>>
>>>    probe process("qemu").mark("qemu_malloc") {
>>>      printf("Malloc %d %p\n", $arg1, $arg2);
>>>    }
>>>
>>> * .gitignore: Ignore trace-dtrace.*
>>> * Makefile: Extra rules for generating DTrace files
>>> * Makefile.obj: Don't build trace.o for DTrace, use
>>>    trace-dtrace.o generated by 'dtrace' instead
>>> * tracetool: Support for generating DTrace data files
>>>
>>> Signed-off-by: Daniel P. Berrange<berrange@redhat.com>
>>>
>>>        
>> Applied both.  Thanks.
>>      
>
> I'm afraid you have applied an old version of the patches. Please
> revert these, and apply version 6, from Nov 12th
>    

Sure, sorry about that.

But in the future, please indicate the version somewhere in the patch 
(preferrably the header).

Regards,

Anthony Liguori

> http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg01033.html
>
> Regards,
> Daniel
>