All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mariusz Białończyk" <manio@skyboo.net>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH] V4L/DVB: cx88: Add module parameter to disable IR
Date: Thu, 18 Nov 2010 08:24:28 +0100	[thread overview]
Message-ID: <4CE4D4AC.5060201@skyboo.net> (raw)
In-Reply-To: <1290062581.41867.321546213719.1.gpush@pororo>

On 2010-11-18 07:43, Jeremy Kerr wrote:
> Currently, the cx88-input code unconditionally establishes an input
> device for IR events. On some cards, this sets up a hrtimer to poll the
> IR status frequently - I get around 200 wakeups per second from this
> polling, and don't use the IR ports.
>
> Although the hrtimer is only run when the input device is opened, the
> device is actually unconditionally opened by kbd_connect, because we
> have the EV_KEY bit set in the input device descriptor. In effect, the
> IR device is always opened (and so polling) if CONFIG_VT.
>
> This change adds a module parameter, 'ir_disable' to disable the IR
> code, and not register this input device at all. This drastically
> reduces the number of wakeups per second for me.

AFAIK we have disable support in cx88:
http://git.linuxtv.org/media_tree.git?a=commit;h=89c3bc78075042ae1f4452687f626acce06b3b21

isn't it related with your patch?

-- 
Mariusz Białończyk
jabber/e-mail: manio@skyboo.net
http://manio.skyboo.net

  reply	other threads:[~2010-11-18  7:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18  6:43 [PATCH] V4L/DVB: cx88: Add module parameter to disable IR Jeremy Kerr
2010-11-18  7:24 ` Mariusz Białończyk [this message]
     [not found] ` <4CE4D3D5.5090108@skyboo.net>
2010-11-18  7:30   ` Jeremy Kerr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE4D4AC.5060201@skyboo.net \
    --to=manio@skyboo.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.