From: Tejun Heo <tj@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, hpa@zytor.com, x86@kernel.org,
eric.dumazet@gmail.com, yinghai@kernel.org
Subject: Re: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mapping early during boot
Date: Thu, 18 Nov 2010 09:39:49 +0100 [thread overview]
Message-ID: <4CE4E655.30207@kernel.org> (raw)
In-Reply-To: <20101118083045.GB26398@elte.hu>
Hey, Ingo.
On 11/18/2010 09:30 AM, Ingo Molnar wrote:
> This patch is still _WAY_ too large.
Really? Alright, I'll split it further.
> Also, these:
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
> Are rather ugly.
Yeah, what they do is ugly. It gets less uglier after the patchset.
I'll see if some of them can be dropped but I don't think putting them
inside ifdef'd inline functions necessarily improves things. It often
just makes things more difficult to follow.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-11-18 8:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 11:02 [PATCHSET RFC] x86: unify x86_32 and 64 NUMA init paths Tejun Heo
2010-11-11 11:02 ` [PATCH 1/9] x86: Kill unused static boot_cpu_logical_apicid in smpboot.c Tejun Heo
2010-11-11 11:13 ` Pekka Enberg
2010-11-11 11:02 ` [PATCH 2/9] x86: Rename x86_32 MAX_APICID to MAX_LOCAL_APIC Tejun Heo
2010-11-11 11:15 ` Pekka Enberg
2010-11-11 11:02 ` [PATCH 3/9] x86: Make default_send_IPI_mask_sequence/allbutself_logical() 32bit only Tejun Heo
2010-11-11 12:02 ` Pekka Enberg
2010-11-11 16:18 ` Cyrill Gorcunov
2010-11-11 17:34 ` [PATCH UPDATED " Tejun Heo
2010-11-11 17:52 ` Cyrill Gorcunov
2010-11-11 11:02 ` [PATCH 4/9] x86: Initialize 32bit logical apicid mapping early during boot Tejun Heo
2010-11-12 1:54 ` Brian Gerst
2010-11-12 9:38 ` [PATCH UPDATED " Tejun Heo
2010-11-12 9:58 ` Yinghai Lu
2010-11-12 10:22 ` Tejun Heo
2010-11-12 10:33 ` [PATCH 4/9 UPDATED-1] " Tejun Heo
2010-11-18 8:30 ` Ingo Molnar
2010-11-18 8:39 ` Tejun Heo [this message]
2010-11-18 8:42 ` Ingo Molnar
2010-11-18 8:48 ` Tejun Heo
2010-11-18 9:08 ` Ingo Molnar
2010-11-11 11:02 ` [PATCH 5/9] x86: Replace apic->apicid_to_node() with ->numa_cpu_node() Tejun Heo
2010-11-11 11:37 ` Pekka Enberg
2010-11-11 11:02 ` [PATCH 6/9] x86: Unify cpu/apicid <-> NUMA node mapping between 32 and 64bit Tejun Heo
2010-11-11 12:01 ` Pekka Enberg
2010-11-11 11:02 ` [PATCH 7/9] x86: Unify CPU -> " Tejun Heo
2010-11-11 11:02 ` [PATCH 8/9] x86: Unify node_to_cpumask_map handling " Tejun Heo
2010-11-11 12:11 ` Pekka Enberg
2010-11-11 11:02 ` [PATCH 9/9] x86: Unify NUMA initialization " Tejun Heo
2010-11-11 12:09 ` Pekka Enberg
2010-11-12 10:32 ` [PATCH 3.5/9] x86: Use local variable to cache smp_processor_id() in setup_local_APIC() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE4E655.30207@kernel.org \
--to=tj@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.