From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hidetoshi Seto Subject: Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT Date: Thu, 18 Nov 2010 17:48:37 +0900 Message-ID: <4CE4E865.6080900@jp.fujitsu.com> References: <4CE47643.7030808@jp.fujitsu.com> <4CE4DD91.9050209@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Chris Wright , "M. Mohan Kumar" , "Hao, Xudong" , Blue Swirl , Avi Kivity To: Jes Sorensen Return-path: Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:56949 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755791Ab0KRItK (ORCPT ); Thu, 18 Nov 2010 03:49:10 -0500 Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oAI8n7bN006259 for (envelope-from seto.hidetoshi@jp.fujitsu.com); Thu, 18 Nov 2010 17:49:07 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 27C3145DE4E for ; Thu, 18 Nov 2010 17:49:07 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id D698945DE51 for ; Thu, 18 Nov 2010 17:49:06 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 6A64F1DB803C for ; Thu, 18 Nov 2010 17:49:06 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id C76C61DB803A for ; Thu, 18 Nov 2010 17:49:05 +0900 (JST) In-Reply-To: <4CE4DD91.9050209@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: (2010/11/18 17:02), Jes Sorensen wrote: > On 11/18/10 01:41, Hidetoshi Seto wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' >> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat' >> >> and: >> >> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': >> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this function) >> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once >> hw/virtio-9p.c:1410: error: for each function it appears in.) >> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function) >> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': >> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) >> >> v4: >> - Use tv_now.tv_usec >> - Rebased on latest qemu.git >> v3: >> - Use better alternative handling for UTIME_NOW/OMIT >> - Move qemu_utimensat() to cutils.c >> V2: >> - Introduce qemu_utimensat() >> >> Acked-by: Chris Wright >> Acked-by: M. Mohan Kumar >> Signed-off-by: Hidetoshi Seto > > Hi Hidetoshi, > > I think the idea of the patch is good, but please move qemu_utimensat() > to oslib-posix.c and provide a wrapper for oslib-win32.c. It is > emulation for a system library function, so it doesn't belong in > cutils.c, but rather in the oslib group. Unfortunately one fact is that I'm not familiar with win32 codes so I don't have any idea how the wrapper for win32 will be... If someone could kindly tell me about the win32 part, I could update this patch to v5, but even though I have no test environment for the new part :-< Could we wait an incremental patch on this v4? Can somebody help me? Volunteers? Thanks, H.Seto From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34109 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ0B9-0004YX-1X for qemu-devel@nongnu.org; Thu, 18 Nov 2010 03:49:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ0B7-0003gv-V4 for qemu-devel@nongnu.org; Thu, 18 Nov 2010 03:49:14 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:48882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ0B7-0003gm-Fn for qemu-devel@nongnu.org; Thu, 18 Nov 2010 03:49:13 -0500 Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oAI8n6ck026350 for (envelope-from seto.hidetoshi@jp.fujitsu.com); Thu, 18 Nov 2010 17:49:06 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 62BE745DE52 for ; Thu, 18 Nov 2010 17:49:06 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 3DFE145DE4E for ; Thu, 18 Nov 2010 17:49:06 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1F9031DB8040 for ; Thu, 18 Nov 2010 17:49:06 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id CCDB51DB803E for ; Thu, 18 Nov 2010 17:49:05 +0900 (JST) Message-ID: <4CE4E865.6080900@jp.fujitsu.com> Date: Thu, 18 Nov 2010 17:48:37 +0900 From: Hidetoshi Seto MIME-Version: 1.0 References: <4CE47643.7030808@jp.fujitsu.com> <4CE4DD91.9050209@redhat.com> In-Reply-To: <4CE4DD91.9050209@redhat.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Blue Swirl , "kvm@vger.kernel.org" , "Hao, Xudong" , "qemu-devel@nongnu.org" , Chris Wright , "M. Mohan Kumar" , Avi Kivity (2010/11/18 17:02), Jes Sorensen wrote: > On 11/18/10 01:41, Hidetoshi Seto wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' >> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat' >> >> and: >> >> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': >> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this function) >> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once >> hw/virtio-9p.c:1410: error: for each function it appears in.) >> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function) >> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': >> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) >> >> v4: >> - Use tv_now.tv_usec >> - Rebased on latest qemu.git >> v3: >> - Use better alternative handling for UTIME_NOW/OMIT >> - Move qemu_utimensat() to cutils.c >> V2: >> - Introduce qemu_utimensat() >> >> Acked-by: Chris Wright >> Acked-by: M. Mohan Kumar >> Signed-off-by: Hidetoshi Seto > > Hi Hidetoshi, > > I think the idea of the patch is good, but please move qemu_utimensat() > to oslib-posix.c and provide a wrapper for oslib-win32.c. It is > emulation for a system library function, so it doesn't belong in > cutils.c, but rather in the oslib group. Unfortunately one fact is that I'm not familiar with win32 codes so I don't have any idea how the wrapper for win32 will be... If someone could kindly tell me about the win32 part, I could update this patch to v5, but even though I have no test environment for the new part :-< Could we wait an incremental patch on this v4? Can somebody help me? Volunteers? Thanks, H.Seto