From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT Date: Thu, 18 Nov 2010 10:09:32 +0100 Message-ID: <4CE4ED4C.9080306@redhat.com> References: <4CE47643.7030808@jp.fujitsu.com> <4CE4DD91.9050209@redhat.com> <4CE4E865.6080900@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Chris Wright , "M. Mohan Kumar" , "Hao, Xudong" , Blue Swirl , Avi Kivity To: Hidetoshi Seto Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25023 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808Ab0KRJJt (ORCPT ); Thu, 18 Nov 2010 04:09:49 -0500 In-Reply-To: <4CE4E865.6080900@jp.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/18/10 09:48, Hidetoshi Seto wrote: > (2010/11/18 17:02), Jes Sorensen wrote: >> Hi Hidetoshi, >> >> I think the idea of the patch is good, but please move qemu_utimensat() >> to oslib-posix.c and provide a wrapper for oslib-win32.c. It is >> emulation for a system library function, so it doesn't belong in >> cutils.c, but rather in the oslib group. > > Unfortunately one fact is that I'm not familiar with win32 codes so I don't > have any idea how the wrapper for win32 will be... > If someone could kindly tell me about the win32 part, I could update this > patch to v5, but even though I have no test environment for the new part :-< > > Could we wait an incremental patch on this v4? > Can somebody help me? Volunteers? Hi Hidetoshi, I don't actually know much about win32 myself, the only thing I do is to try and cross-compile for it using mingw32 to make sure the build doesn't break. One option is to leave it open, or put in a dummy wrapper which asserts in the win32 part of the code, so that someone who is interested in win32 can fix it up. That should be pretty easy to do, and I think thats a fine starting point. Cheers, Jes From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60601 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ0Uz-0002Ka-PB for qemu-devel@nongnu.org; Thu, 18 Nov 2010 04:09:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ0Uy-0007TF-PU for qemu-devel@nongnu.org; Thu, 18 Nov 2010 04:09:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ0Uy-0007T4-Ij for qemu-devel@nongnu.org; Thu, 18 Nov 2010 04:09:44 -0500 Message-ID: <4CE4ED4C.9080306@redhat.com> Date: Thu, 18 Nov 2010 10:09:32 +0100 From: Jes Sorensen MIME-Version: 1.0 References: <4CE47643.7030808@jp.fujitsu.com> <4CE4DD91.9050209@redhat.com> <4CE4E865.6080900@jp.fujitsu.com> In-Reply-To: <4CE4E865.6080900@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hidetoshi Seto Cc: Blue Swirl , "kvm@vger.kernel.org" , "Hao, Xudong" , "qemu-devel@nongnu.org" , Chris Wright , "M. Mohan Kumar" , Avi Kivity On 11/18/10 09:48, Hidetoshi Seto wrote: > (2010/11/18 17:02), Jes Sorensen wrote: >> Hi Hidetoshi, >> >> I think the idea of the patch is good, but please move qemu_utimensat() >> to oslib-posix.c and provide a wrapper for oslib-win32.c. It is >> emulation for a system library function, so it doesn't belong in >> cutils.c, but rather in the oslib group. > > Unfortunately one fact is that I'm not familiar with win32 codes so I don't > have any idea how the wrapper for win32 will be... > If someone could kindly tell me about the win32 part, I could update this > patch to v5, but even though I have no test environment for the new part :-< > > Could we wait an incremental patch on this v4? > Can somebody help me? Volunteers? Hi Hidetoshi, I don't actually know much about win32 myself, the only thing I do is to try and cross-compile for it using mingw32 to make sure the build doesn't break. One option is to leave it open, or put in a dummy wrapper which asserts in the win32 part of the code, so that someone who is interested in win32 can fix it up. That should be pretty easy to do, and I think thats a fine starting point. Cheers, Jes