From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55105 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJ5NG-0002Et-Mc
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:22:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ5NF-00050q-E4
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:22:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26452)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ5NF-00050k-3g
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:22:05 -0500
Message-ID: <4CE53688.9070607@redhat.com>
Date: Thu, 18 Nov 2010 15:22:00 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH v4 14/18] virtagent: add
	client	capabilities init function
References: <1289923320-5638-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1289923320-5638-15-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1289923320-5638-15-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, abeekhof@redhat.com

On 11/16/10 17:01, Michael Roth wrote:
> Non-monitor version of agent_capabilities monitor function. This is
> called by the local RPC server when it gets a "hello" from the guest
> agent to re-negotiate guest agent capabilities.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  virtagent.c |   34 ++++++++++++++++++++++++++++++++++
>  virtagent.h |    1 +
>  2 files changed, 35 insertions(+), 0 deletions(-)
> 
> diff --git a/virtagent.c b/virtagent.c
> index e0f7f99..4ec1b42 100644
> --- a/virtagent.c
> +++ b/virtagent.c
> @@ -694,3 +694,37 @@ int do_agent_capabilities(Monitor *mon, const QDict *mon_params,
>  
>      return 0;
>  }
> +
> +/* non-HMP/QMP RPC client functions */
> +
> +int va_client_init_capabilities(void)
> +{
> +    xmlrpc_env env;
> +    xmlrpc_value *params;
> +    VARPCData *rpc_data;
> +    int ret;
> +
> +    xmlrpc_env_init(&env);
> +
> +    params = xmlrpc_build_value(&env, "()");
> +    if (rpc_has_error(&env)) {
> +        return -1;
> +    }
> +
> +    rpc_data = qemu_mallocz(sizeof(VARPCData));
> +    rpc_data->cb = do_agent_capabilities_cb;
> +    rpc_data->mon_cb = NULL;
> +    rpc_data->mon_data = NULL;
> +
> +    ret = rpc_execute(&env, "system.listMethods", params, rpc_data);
> +    if (ret == -EREMOTE) {
> +        LOG("RPC Failed (%i): %s\n", env.fault_code,
> +            env.fault_string);
> +        return -1;
> +    } else if (ret == -1) {
> +        LOG("RPC communication error\n");
> +        return -1;
> +    }

One of many examples that would have benefited from having a utility
function doing most of the work here.

Cheers,
Jes