Re: [PATCH] tar: upgrade to version 1.25

[Scott Garman <sgarman@zenlinux.com>]

On 11/18/2010 12:34 AM, Martin Jansa wrote:
>>>>> Can you add tar-1.23 to the removal.txt file? Ask it be removed in a
>>>>> couple of months. This way we have a schedule to delete the older recipe.
>>>>
>>>> Thanks for the quick ack, Philip. Question though on the removal.txt
>>>> addition - this patch deletes the v1.23 version already. Does it need to
>>>> be kept around instead? I would think not given that this is a pretty
>>>> trivial update.
>>>>
>>>> Perhaps you meant tar v1.18 and/or v1.20, which are still there?
>>>
>>> Oops, I wasn't paying that close attention. I'd still leave 1.23 around for
>>> a couple of months, just in case there is some weird issue with 1.25. We
>>> should check on the older ones and add them to removal.txt also. I'd like to
>>> see us get into a sane clean up old stuff cycle, instead of the delete
>>> everything at once approach. Of course checking to see if any in tree
>>> distros use them is  good thing.
>>>
>>
>> Yeah probably a sane thing. Make 1.25 default and let 1.23 linger
>> around for a while
>> just in case.
>
> Gentoo already has serious bug reported against 1.25
> http://bugs.gentoo.org/342983
> resulting in added 1.25 being masked now there
>
> Maybe we should keep 1.23 default until it's resolved or confirmed
> that OE is not affected by this.

Thanks Martin for that research. I'm going to remove my patch from 
patchwork and look into this further. If the bug against 1.25 doesn't 
look like it will affect us, I will re-submit the patch such that 1.23 
is kept around. Otherwise we may be better off simply waiting for 
another release of tar.

FWIW tar 1.25 came out only two weeks after 1.24, which implies to me 
that they were fixing some relatively urgent bugs. As mentioned on the 
tar home page, these issues were reportedly fixed in 1.25:

* Fix extraction of empty directories with the -C option in effect
* Fix extraction of device nodes
* Make sure name matching occurs before eventual name transformation
* Fix the behavior of tar -x --overwrite on hosts lacking O_NOFOLLOW.
* Improve the testsuite

I also maintain the tar recipe for Poky, so I'll investigate further.

Scott

-- 
Scott Garman
sgarman at zenlinux dot com