From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36317 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJ8rc-0004DP-DJ
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 13:05:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PJ8ra-0003Vu-5m
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 13:05:40 -0500
Received: from cantor.suse.de ([195.135.220.2]:56108 helo=mx1.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PJ8ra-0003Uf-0b
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 13:05:38 -0500
Message-ID: <4CE56AED.8070906@suse.de>
Date: Thu, 18 Nov 2010 19:05:33 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1290050875-23848-1-git-send-email-agraf@suse.de>
	<1290050875-23848-9-git-send-email-agraf@suse.de>
	<4CE4DD74.3070801@redhat.com>
In-Reply-To: <4CE4DD74.3070801@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/10] ahci: add ahci emulation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Joerg Roedel <Joerg.Roedel@amd.com>, QEMU-devel Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@gmail.com>, tj@kernel.org, Roland Elek <elek.roland@gmail.com>, Sebastian Herbszt <herbszt@gmx.de>

Gerd Hoffmann wrote:
>   Hi,
>
>> +static void ahci_trigger_irq(AHCIState *s, AHCIDevice *d,
>> +                             int irq_type)
>
>> +static void ahci_check_irq(AHCIState *s)
>
> MSI support would be nice to have.

Alrighty, I added MSI support. But I only have a single vector in use
atm as nvec > 0 doesn't get written to the PCI config space so the code
trips on that later on.

[...]

>
>> +        if (dinfo) {
>> +            ide_create_drive(&ad->port, 0, dinfo);
>> +        }
>
> That doesn't belong into the qdev init function.
>
> Look how ide/isa.c handles it:  The qdev init function
> (isa_ide_initfn) doesn't create ide-drives at all.  And there is a
> convinience function (isa_ide_init) which first creates the
> controller, then attaches the drives.  The later is called from
> pc_init() with the drives specified via -drive if=ide (or -hda).

Hrm. I guess I'll just put it into the PC specific initialization
function :).

>
> Does AHCI support drive hotplug btw?

AHCI does, my code does not yet :). Feel free to add support for it! :D


Alex