Re: [PATCH] Eliminate error handler overload of the SCSI serial number

[Mike Christie <michaelc@cs.wisc.edu>]

On 11/18/2010 01:36 PM, Mike Christie wrote:
> On 11/17/2010 10:10 AM, James Bottomley wrote:
>> -static int scsi_try_to_abort_cmd(struct scsi_cmnd *scmd)
>> -{
>> - /*
>> - * scsi_done was called just after the command timed out and before
>> - * we had a chance to process it. (db)
>> - */
>> - if (scmd->serial_number == 0)
>> - return SUCCESS;
>> - return __scsi_try_to_abort_cmd(scmd);
>> -}
>
> Does it matter that with this patch we now call the driver's abort
> handler when the command has been added to the eh list when going
> through scsi_softirq_done-> scsi_decide_disposition returns FAILED ->
> scsi_eh_scmd_add?
>

Ignore this. I see scsi_eh_scmd_add passes the 0 flag, so the abort 
handler is not called.