From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34349 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJN8x-0001AT-Dv
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 04:20:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJN8s-0006HG-63
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 04:20:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39819)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJN8r-0006Gz-Td
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 04:20:26 -0500
Message-ID: <4CE64151.7050601@redhat.com>
Date: Fri, 19 Nov 2010 10:20:17 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation
References: <20101118144755.442B2F90AB@ochil.suse.de>
In-Reply-To: <20101118144755.442B2F90AB@ochil.suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com

On 11/18/10 15:47, Hannes Reinecke wrote:
> This patch adds an emulation for the LSI Megaraid SAS HBA.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  Makefile.objs |    2 +-
>  hw/megasas.c  | 1826 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/mfi.h      | 1197 +++++++++++++++++++++++++++++++++++++
>  hw/pci_ids.h  |    2 +
>  hw/scsi.h     |    1 +
>  5 files changed, 3027 insertions(+), 1 deletions(-)
>  create mode 100644 hw/megasas.c
>  create mode 100644 hw/mfi.h
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index 15569af..54c6e02 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -231,7 +231,7 @@ hw-obj-$(CONFIG_IDE_MACIO) += ide/macio.o
>  hw-obj-$(CONFIG_IDE_VIA) += ide/via.o
>  
>  # SCSI layer
> -hw-obj-y += lsi53c895a.o
> +hw-obj-y += lsi53c895a.o megasas.o
>  hw-obj-$(CONFIG_ESP) += esp.o
>  
>  hw-obj-y += dma-helpers.o sysbus.o isa-bus.o

Just had a look through your patches and have to say nice work. Haven't
tested it though, but looks like a good step in the right direction.

Only comment, as you are adding another SCSI driver, maybe it's time to
make the driver selection configurable, rather than hard coding the build?

Cheers,
Jes