From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/6] build: tag function headers rather than decls as exported
Date: Fri, 19 Nov 2010 12:43:24 +0100 [thread overview]
Message-ID: <4CE662DC.401@netfilter.org> (raw)
In-Reply-To: <alpine.LNX.2.01.1011191225260.31107@obet.zrqbmnf.qr>
On 19/11/10 12:26, Jan Engelhardt wrote:
>
> On Friday 2010-11-19 12:09, Pablo Neira Ayuso wrote:
>>
>> I like this patchset. Some minor glitch:
>>
>> On 16/11/10 12:43, Jan Engelhardt wrote:
>>> @@ -49,31 +43,31 @@ MNL_API int mnl_socket_getsockopt(const struct mnl_socket *nl, int type, void *b
>>> -MNL_API size_t mnl_nlmsg_size(size_t len);
>>> -MNL_API size_t mnl_nlmsg_total_size(size_t len);
>>> -MNL_API size_t mnl_nlmsg_get_payload_len(const struct nlmsghdr *nlh);
>>> +extern size_t mnl_nlmsg_size(size_t len);
>>> +extern size_t mnl_nlmsg_total_size(size_t len);
>>> +extern size_t mnl_nlmsg_get_payload_len(const struct nlmsghdr *nlh);
>>
>> In patch 1/6 mnl_nlmsg_next looks like:
>>
>> -struct nlattr *mnl_attr_next(const struct nlattr *attr, int *len)
>> +struct nlattr *mnl_attr_next(const struct nlattr *attr)
>>
>> but here the old API seems to come back:
>>
>> extern struct nlmsghdr *mnl_nlmsg_next(const struct nlmsghdr *nlh, int
>> *len);
>
> I only changed the attr iteration interface so far, but not yet
> that of nlmsg iteration.
Oh, I didn't notice that this refers to nlmsg, not to attr. I'll apply
the remaining patches then. Thanks.
next prev parent reply other threads:[~2010-11-19 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 11:43 libmnl: proposed patches 20101116 Jan Engelhardt
2010-11-16 11:43 ` [PATCH 1/6] attr: avoid multiple definition of hidden variable Jan Engelhardt
2010-11-16 11:43 ` [PATCH 2/6] socket: propagate sendto/recvmsg's return types Jan Engelhardt
2010-11-16 11:43 ` [PATCH 3/6] Update .gitignore Jan Engelhardt
2010-11-16 11:43 ` [PATCH 4/6] build: tag function headers rather than decls as exported Jan Engelhardt
2010-11-19 11:09 ` Pablo Neira Ayuso
2010-11-19 11:26 ` Jan Engelhardt
2010-11-19 11:43 ` Pablo Neira Ayuso [this message]
2010-11-16 11:43 ` [PATCH 5/6] build: add some more precautionary CFLAGS Jan Engelhardt
2010-11-16 11:43 ` [PATCH 6/6] nlmsg: remove unused function Jan Engelhardt
2010-11-19 11:16 ` libmnl: proposed patches 20101116 Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE662DC.401@netfilter.org \
--to=pablo@netfilter.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.