All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"device-drivers-devel@blackfin.uclinux.org"
	<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: RFC: more consitent DAC sysfs attributes naming
Date: Fri, 19 Nov 2010 12:18:24 +0000	[thread overview]
Message-ID: <4CE66B10.80605@cam.ac.uk> (raw)
In-Reply-To: <544AC56F16B56944AEC3BD4E3D591771312EE15286@LIMKCMBX1.ad.analog.com>

On 11/19/10 08:33, Hennerich, Michael wrote:
> Hi Jonathan,
> 
> I wonder if it would make more sense to use this...
> 
> drivers/staging/iio/dac/dac.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/iio/dac/dac.h b/drivers/staging/iio/dac/dac.h
> index 55005ee..62620ed 100644
> --- a/drivers/staging/iio/dac/dac.h
> +++ b/drivers/staging/iio/dac/dac.h
> @@ -2,5 +2,9 @@
>   * dac.h - sysfs attributes associated with DACs
>   */
> 
> +/* Deprecated */
>  #define IIO_DEV_ATTR_DAC(_num, _store, _addr)                  \
>         IIO_DEVICE_ATTR(dac_##_num, S_IWUSR, NULL, _store, _addr)
> +
> +#define IIO_DEV_ATTR_OUT_RAW(_num, _show, _addr)                               \
> +       IIO_DEVICE_ATTR(out##_num##_raw, S_IWUSR, _show, NULL, _addr)
Yes, that seems like the logical equivalent to in0_raw to me.
> 
> 
> Greetings,
> Michael
> 
> --
> Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
> Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036
> Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
> 
> 


      reply	other threads:[~2010-11-19 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  8:33 RFC: more consitent DAC sysfs attributes naming Hennerich, Michael
2010-11-19 12:18 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE66B10.80605@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=Michael.Hennerich@analog.com \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.