From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: stefanha@gmail.com, kraxel@redhat.com,
Hannes Reinecke <hare@suse.de>,
nab@linux-iscsi.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation
Date: Fri, 19 Nov 2010 15:31:28 +0100 [thread overview]
Message-ID: <4CE68A40.5020700@redhat.com> (raw)
In-Reply-To: <m3lj4pl86o.fsf@blackfin.pond.sub.org>
On 11/19/10 15:06, Markus Armbruster wrote:
>> Only comment, as you are adding another SCSI driver, maybe it's time to
>> make the driver selection configurable, rather than hard coding the build?
>
> What do you mean by that?
>
> We hardcode lsi53c895a in two places where we really mean "default SCSI
> controller type": pc_pci_device_init(), which applies to "-drive
> if=scsi", and qemu_pci_hot_add_storage(), which applies to "pci_add
> storage if=scsi". Not sure making that default configurable is worth
> it.
>
> If you want more control than -drive and pci_add provice, use -device
> and device_add.
What I mean is for most other device types we allow to specify a list of
wanted devices at the configure line, which is what I am suggesting we
added support for for SCSI as well.
Cheers,
Jes
next prev parent reply other threads:[~2010-11-19 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 14:47 [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation Hannes Reinecke
2010-11-19 9:20 ` Jes Sorensen
2010-11-19 14:06 ` Markus Armbruster
2010-11-19 14:19 ` Hannes Reinecke
2010-11-19 14:31 ` Jes Sorensen [this message]
2010-11-19 16:36 ` Alexander Graf
2010-11-19 17:35 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE68A40.5020700@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=hare@suse.de \
--cc=kraxel@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.