From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Sat, 20 Nov 2010 14:54:31 +0300 Subject: [PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map_xfer' In-Reply-To: <1290247733-17834-6-git-send-email-plagnioj@jcrosoft.com> References: <20101120095906.GD4216@game.jcrosoft.org> <1290247733-17834-6-git-send-email-plagnioj@jcrosoft.com> Message-ID: <4CE7B6F7.7080108@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 20-11-2010 13:08, Jean-Christophe PLAGNIOL-VILLARD wrote: > passing argument 2 of 'dma_map_single' discards qualifiers from pointer target type > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > drivers/spi/atmel_spi.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > diff --git a/drivers/spi/atmel_spi.c b/drivers/spi/atmel_spi.c > index 154529a..2cf6abd 100644 > --- a/drivers/spi/atmel_spi.c > +++ b/drivers/spi/atmel_spi.c > @@ -352,8 +352,10 @@ atmel_spi_dma_map_xfer(struct atmel_spi *as, struct spi_transfer *xfer) > > xfer->tx_dma = xfer->rx_dma = INVALID_DMA_ADDRESS; > if (xfer->tx_buf) { > + void *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */ > + Aren't casts to 'void *' automatic? > xfer->tx_dma = dma_map_single(dev, > - (void *) xfer->tx_buf, xfer->len, > + nonconst_tx, xfer->len, > DMA_TO_DEVICE); > if (dma_mapping_error(dev, xfer->tx_dma)) > return -ENOMEM; WBR, Sergei