From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects
Date: Sun, 21 Nov 2010 13:31:24 +0100 [thread overview]
Message-ID: <4CE9111C.3010708@redhat.com> (raw)
In-Reply-To: <7BADF5D6-2BE4-4F2B-A241-24D6BD45DD8E@web.de>
On 11/20/10 18:22, Andreas Färber wrote:
> Am 19.11.2010 um 17:30 schrieb Jes.Sorensen@redhat.com:
>
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>> ---
>> Makefile | 2 +-
>> Makefile.objs | 12 ++++++++++--
>> 2 files changed, 11 insertions(+), 3 deletions(-)
>
> Tested-by: Andreas Färber <andreas.faerber@web.de>
>
> Looks good to me and a clean build works okay.
>
> Any plans for a way to disable NBD build completely? There are warnings
> about use of daemon() on Mac OS X and possibly Solaris, and there's
> little point in building qemu-nbd if one does not use it.
I think it would be worth adding as an option, however letting it
default to 'on' to make sure it gets at least build tested unless a user
explicitly disables it.
Cheers,
Jes
next prev parent reply other threads:[~2010-11-21 12:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 16:30 [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects Jes.Sorensen
2010-11-20 17:22 ` Andreas Färber
2010-11-20 17:39 ` Stefan Hajnoczi
2010-11-20 18:04 ` Andreas Färber
2010-11-20 18:31 ` Stefan Hajnoczi
2010-11-21 12:30 ` Jes Sorensen
2010-11-21 12:31 ` Jes Sorensen [this message]
2010-11-22 12:24 ` Kevin Wolf
2010-11-22 14:08 ` Jes Sorensen
2010-11-22 14:15 ` Kevin Wolf
2010-11-22 14:27 ` Jes Sorensen
2010-11-22 14:38 ` Kevin Wolf
2010-11-22 14:53 ` Jes Sorensen
2010-11-22 14:54 ` Anthony Liguori
2010-11-22 14:58 ` Jes Sorensen
2010-11-22 15:08 ` Anthony Liguori
2010-11-22 15:10 ` Jes Sorensen
2010-11-22 15:20 ` Anthony Liguori
2010-11-22 15:23 ` Jes Sorensen
2010-12-10 12:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE9111C.3010708@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.