From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH v3 0/2] Type-safe ioport callbacks Date: Sun, 21 Nov 2010 09:18:49 -0600 Message-ID: <4CE93859.3080703@codemonkey.ws> References: <1289987410-466-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:34018 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753532Ab0KUPTA (ORCPT ); Sun, 21 Nov 2010 10:19:00 -0500 Received: by gyb11 with SMTP id 11so833052gyb.19 for ; Sun, 21 Nov 2010 07:19:00 -0800 (PST) In-Reply-To: <1289987410-466-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/17/2010 03:50 AM, Avi Kivity wrote: > A not-so-recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler > complaining because of the type-unsafeness of the ioport callbacks. This > patchset adds a type-safe variant of ioport callbacks and coverts a sample > ioport. Converting the other 300-odd registrations is left as an excercise > to the community. > Applied all. Thanks. Regards, Anthony Liguori > v3: > - define a common IORange that can also be used for mmio > - move start/length into IORange > - make access width a parameter of the access functions instead of > having a callback per access size > > v2: > - const correctness > - avoid return void > > Avi Kivity (2): > Type-safe ioport callbacks > piix4 acpi: convert io BAR to type-safe ioport callbacks > > hw/acpi_piix4.c | 55 +++++++++++++++++++---------------------------- > ioport.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ioport.h | 2 + > iorange.h | 30 +++++++++++++++++++++++++ > 4 files changed, 118 insertions(+), 33 deletions(-) > create mode 100644 iorange.h > >