From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49422 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKBia-0005tN-V0
	for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:20:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PKBiZ-0004eP-OM
	for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:20:40 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:45384)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PKBiZ-0004eL-Kb
	for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:20:39 -0500
Received: by gye5 with SMTP id 5so1586539gye.4
	for <qemu-devel@nongnu.org>; Sun, 21 Nov 2010 07:20:39 -0800 (PST)
Message-ID: <4CE938C4.5030306@codemonkey.ws>
Date: Sun, 21 Nov 2010 09:20:36 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] trace: Trace vm_start()/vm_stop()
References: <1289910025-25448-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1289910025-25448-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>

On 11/16/2010 06:20 AM, Stefan Hajnoczi wrote:
> VM state change notifications are invoked from vm_start()/vm_stop().
> Trace these state changes so we can reason about the state of the VM
> from trace output.
>
> Signed-off-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   trace-events |    3 +++
>   vl.c         |    3 +++
>   2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 947f8b0..da03d4b 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -189,3 +189,6 @@ disable sun4m_iommu_mem_writel_pgflush(uint32_t val) "page flush %x"
>   disable sun4m_iommu_page_get_flags(uint64_t pa, uint64_t iopte, uint32_t ret) "get flags addr %"PRIx64" =>  pte %"PRIx64", *pte = %x"
>   disable sun4m_iommu_translate_pa(uint64_t addr, uint64_t pa, uint32_t iopte) "xlate dva %"PRIx64" =>  pa %"PRIx64" iopte = %x"
>   disable sun4m_iommu_bad_addr(uint64_t addr) "bad addr %"PRIx64""
> +
> +# vl.c
> +disable vm_state_notify(int running, int reason) "running %d reason %d"
> diff --git a/vl.c b/vl.c
> index c58583d..87e76ad 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -158,6 +158,7 @@ int main(int argc, char **argv)
>
>   #include "slirp/libslirp.h"
>
> +#include "trace.h"
>   #include "qemu-queue.h"
>   #include "cpus.h"
>   #include "arch_init.h"
> @@ -1074,6 +1075,8 @@ void vm_state_notify(int running, int reason)
>   {
>       VMChangeStateEntry *e;
>
> +    trace_vm_state_notify(running, reason);
> +
>       for (e = vm_change_state_head.lh_first; e; e = e->entries.le_next) {
>           e->cb(e->opaque, running, reason);
>       }
>