Re: [RFC PATCH 1/2] common: add long dial string support

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]

Hi Andras,

On 11/18/2010 05:38 AM, Arun Ravindran wrote:
> Hi Denis, Marcel, Andras,
> 
>>   include/types.h |    2 +-
>>   src/common.c    |   12 ++++++------
>>   2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/include/types.h b/include/types.h
>> index ba2481f..b3d2247 100644
>> --- a/include/types.h
>> +++ b/include/types.h
>> @@ -76,7 +76,7 @@ struct ofono_error {
>>       int error;
>>   };
>>
>> -#define OFONO_MAX_PHONE_NUMBER_LENGTH 20
>> +#define OFONO_MAX_PHONE_NUMBER_LENGTH 120
>>
>>   struct ofono_phone_number {
>>       char number[OFONO_MAX_PHONE_NUMBER_LENGTH + 1];
>> diff --git a/src/common.c b/src/common.c
>> index b5b9a6f..de5a508 100644
>> --- a/src/common.c
>> +++ b/src/common.c
>> @@ -253,7 +253,7 @@ gboolean valid_phone_number_format(const char
>> *number)
>>           if (number[i]>= '0'&&  number[i]<= '9')
>>               continue;
>>
>> -        if (number[i] == '*' || number[i] == '#')
>> +        if (number[i] == '*' || number[i] == '#' || number[i] == 'p')
>>               continue;
>>    
> This function is used to check the phone number as valid in other places
> too.
> 
> Is it right to allow sms sending to numbers with '*', '#' and 'p' in it?
> I think ofono should return an error for the sms case.
> 

Arun has nailed it, hacking valid_phone_number_format is not the right
way to go.  You need to separate this out a bit for the particular usecase.

Regards,
-Denis