From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] e1000: fix compile warning
Date: Mon, 22 Nov 2010 12:03:56 +0100 [thread overview]
Message-ID: <4CEA4E1C.2050607@free.fr> (raw)
In-Reply-To: <20101122100748.39E65B191@gemini.denx.de>
Le 22/11/2010 11:07, Wolfgang Denk a ?crit :
> Dear Albert ARIBAUD,
>
> In message<4CEA3A7B.1070602@free.fr> you wrote:
>> Le 22/11/2010 09:48, Wolfgang Denk a ?crit :
>>
>>> - txp->buffer_addr = cpu_to_le64(virt_to_bus(hw->pdev, packet));
>>> + txp->buffer_addr = cpu_to_le64(virt_to_bus(hw->pdev, nv_packet));
>>
>> Wouldn't type-casting packet right here work? e.g.:
>>
>> txp->buffer_addr = cpu_to_le64(virt_to_bus(hw->pdev, ((void*)packet)));
>
> No, it doesn't. The virt_to_bus() macro already has such a
> cast internally, but it doesn't work here.
>
> Best regards,
>
> Wolfgang Denk
Hmm, then maybe it is not the type that causes the warning, but a
qualifier such as 'const' ?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-11-22 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 8:48 [U-Boot] [PATCH] e1000: fix compile warning Wolfgang Denk
2010-11-22 9:40 ` Albert ARIBAUD
2010-11-22 10:07 ` Wolfgang Denk
2010-11-22 11:03 ` Albert ARIBAUD [this message]
2010-11-22 12:02 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA4E1C.2050607@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.