From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking
Date: Mon, 22 Nov 2010 12:28:51 +0100 [thread overview]
Message-ID: <4CEA53F3.5090407@suse.de> (raw)
In-Reply-To: <20101122112032.GA1579@lst.de>
On 11/22/2010 12:20 PM, Christoph Hellwig wrote:
> On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:
>>
>> scsi_req_parse() already provides for a data direction setting,
>> so we should be using it to check for correct direction.
>
> Instead of just a debug printf that almost no one compiles in shouldn't
> we reject the incorrect commands?
>
Good point. Will be fixing it up for the next version.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
prev parent reply other threads:[~2010-11-22 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 14:47 [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking Hannes Reinecke
2010-11-22 11:20 ` Christoph Hellwig
2010-11-22 11:28 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA53F3.5090407@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.