From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39399 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKX48-0000wI-8X for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:08:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKX47-0003u8-3q for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:08:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKX46-0003ti-Qi for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:08:18 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAME8HW8002925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Nov 2010 09:08:17 -0500 Message-ID: <4CEA794F.40506@redhat.com> Date: Mon, 22 Nov 2010 15:08:15 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects References: <1290184248-30078-1-git-send-email-Jes.Sorensen@redhat.com> <4CEA6102.3020709@redhat.com> In-Reply-To: <4CEA6102.3020709@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 11/22/10 13:24, Kevin Wolf wrote: > Am 19.11.2010 17:30, schrieb Jes.Sorensen@redhat.com: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen > > You're compiling the nbd block driver out here. This is certainly not > what you were attempting. (However, it's the only way to make it work, > because otherwise qemu-img will need the top-level nbd.o) > > qemu-img -help before this change shows: > > Supported formats: raw cow qcow vdi vmdk cloop dmg bochs vpc vvfat qcow2 > parallels nbd blkdebug sheepdog blkverify host_cdrom host_floppy > host_device file tftp ftps ftp https http > > Afterwards: > > Supported formats: raw cow qcow vdi vmdk cloop dmg bochs vpc vvfat qcow2 > parallels blkdebug sheepdog blkverify host_cdrom host_floppy host_device > file tftp ftps ftp https http I am aware of that, but what on earth is qemu-img doing with NBD in the first place? Doesn't make much sense to me. Cheers, Jes