From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42265 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKY0x-00011p-3g for qemu-devel@nongnu.org; Mon, 22 Nov 2010 10:09:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKY0r-0000rC-SK for qemu-devel@nongnu.org; Mon, 22 Nov 2010 10:09:06 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:35488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKY0r-0000r8-Q9 for qemu-devel@nongnu.org; Mon, 22 Nov 2010 10:09:01 -0500 Received: by qwb8 with SMTP id 8so1668611qwb.4 for ; Mon, 22 Nov 2010 07:08:58 -0800 (PST) Message-ID: <4CEA8785.2030208@codemonkey.ws> Date: Mon, 22 Nov 2010 09:08:53 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects References: <1290184248-30078-1-git-send-email-Jes.Sorensen@redhat.com> <4CEA6102.3020709@redhat.com> <4CEA794F.40506@redhat.com> <4CEA7AFD.2050609@redhat.com> <4CEA7DBD.9020904@redhat.com> <4CEA806C.8040501@redhat.com> <4CEA8437.4090900@codemonkey.ws> <4CEA8501.9040603@redhat.com> In-Reply-To: <4CEA8501.9040603@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Kevin Wolf , qemu-devel@nongnu.org On 11/22/2010 08:58 AM, Jes Sorensen wrote: > On 11/22/10 15:54, Anthony Liguori wrote: > >> On 11/22/2010 08:38 AM, Kevin Wolf wrote: >> >>> You're free to dislike NBD as much as you want. Just compiling it out >>> unconditionally and calling it a cleanup is a bit too much. ;-) >>> >>> A configure option for disabling NBD sounds reasonable, though I'm not >>> sure what you're trying to achieve with it. It doesn't have any external >>> dependencies that you could avoid this way, does it? >>> >>> >> Using block format whitelisting should be enough to disable nbd. I >> don't see a need for an explicit --disable-nbd option. >> > Right, the right solution is probably to create a block driver list > argument for configure, similar to what we have for the sound drivers. > --block-drv-whitelist= Regards, Anthony Liguori > Ignore my patch. > > Cheers, > Jes >